[GitHub] storm issue #2729: STORM-3064: PartitionedTridentSpoutExecutor should use ge...

2018-06-21 Thread milantracy
Github user milantracy commented on the issue: https://github.com/apache/storm/pull/2729 @srdo @danny0405 squashed, thanks for reviewing :) ---

[GitHub] storm issue #2729: STORM-3064: PartitionedTridentSpoutExecutor should use ge...

2018-06-21 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2729 @milantracy Looks great. Please squash to one commit, and we can merge once the 24 hour waiting period is over. ---

[GitHub] storm issue #2729: STORM-3064: PartitionedTridentSpoutExecutor should use ge...

2018-06-21 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2729 +1, looks good. ---

[GitHub] storm issue #2729: STORM-3064: PartitionedTridentSpoutExecutor should use ge...

2018-06-20 Thread milantracy
Github user milantracy commented on the issue: https://github.com/apache/storm/pull/2729 @srdo could you review this pull request ---