[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/909 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/908 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-10 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/909#issuecomment-163838627 @rfarivar @darionyaphet #908 is a pull to a different branch. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-10 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-163838439 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-02 Thread rfarivar
Github user rfarivar commented on the pull request: https://github.com/apache/storm/pull/909#issuecomment-161369727 The updated links look good, but I don't understand why this can't be part of #908? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-02 Thread rfarivar
Github user rfarivar commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-161369105 The updated links look good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: [GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread Cody Innowhere
@vesense, I see all 3 files are in trunk, maybe you can up-merge your local repository first? On Wed, Dec 2, 2015 at 10:10 AM, darionyaphet wrote: > Github user darionyaphet commented on the pull request: > > https://github.com/apache/storm/pull/909#issuecomment-161156921 > > it's same w

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread darionyaphet
Github user darionyaphet commented on the pull request: https://github.com/apache/storm/pull/909#issuecomment-161156921 it's same with [#908](https://github.com/apache/storm/pull/908) ? If they are the same, please close this PR . --- If your project is set up for it, you can reply

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-161152398 Done.Since files are not in the same branch, I have created a new PR (https://github.com/apache/storm/pull/909) for backtype.storm.Config. --- If your project is set up

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/909 [STORM-1359] change kryo links from google code to github You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-10 Alternatively y

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-161149466 @unsleepy22 Thanks. I will fix that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread unsleepy22
Github user unsleepy22 commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-160996576 Hi vesense, thanks for the PR, but it seems there're 3 files affected by this link: Serialization.md Structure-of-the-Codebase.md backtype.storm.Config L

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/908 [STORM-1359] change kryo links from google code to github You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-9 Alternatively yo