[GitHub] storm pull request: [STORM-1368] change heapdump file permissions ...

2016-02-12 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1078#discussion_r52788111 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -231,7 +231,7 @@ /** * Whether we want to display all the resource

[GitHub] storm pull request: [STORM-1368] change heapdump file permissions ...

2016-02-12 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1078#issuecomment-183461871 Minor nit, then +1 pending travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: [STORM-1368] change heapdump file permissions ...

2016-02-12 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1078#issuecomment-183466471 This breaks windows by default, and is only needed when security is turned on. Why don't we have the logviewer + worker_launcher change the permissions instead of

[GitHub] storm pull request: [STORM-1368] change heapdump file permissions ...

2016-02-04 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/storm/pull/1078 [STORM-1368] change heapdump file permissions so that UI download wil… Change heapdump file permissions so that UI download wil work in secure clusters. a. For automatically generated