Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/973#issuecomment-170591310
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/973#issuecomment-169233427
comments addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/973#discussion_r48929312
--- Diff:
storm-core/src/jvm/storm/trident/state/map/MapReducerAggStateUpdater.java ---
@@ -34,39 +34,38 @@
import storm.trident.tuple.TridentTupleView.Pr
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/973#discussion_r48929303
--- Diff:
storm-core/src/jvm/storm/trident/state/map/MapCombinerAggStateUpdater.java ---
@@ -33,24 +33,25 @@
import storm.trident.tuple.TridentTupleView.P
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/973#issuecomment-169016862
Two very minor comments and then I am +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/973#discussion_r48849445
--- Diff:
storm-core/src/jvm/storm/trident/state/map/MapReducerAggStateUpdater.java ---
@@ -34,39 +34,38 @@
import storm.trident.tuple.TridentTupleView.Pr
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/973#discussion_r48849410
--- Diff:
storm-core/src/jvm/storm/trident/state/map/MapCombinerAggStateUpdater.java ---
@@ -33,24 +33,25 @@
import storm.trident.tuple.TridentTupleView.P
