Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/978#issuecomment-171244000
Thanks @revans2 @hmcl for your explaining. These changes are not necessary.
I will close this issue as 'Not A Problem'.
---
If your project is set up for it, you can
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/978
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/978#issuecomment-170588179
@hmcl and @vesense these changes are not necessary. I pointed out here
https://github.com/apache/storm/pull/977#issuecomment-169101930 that the commit
API should
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/978#issuecomment-169828477
@vesense why is this change necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/978
[STORM-1420] solr CountBasedCommit should reset count=0 after commited
https://issues.apache.org/jira/browse/STORM-1420
You can merge this pull request into a Git repository by running:
$ git
