Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/1173#issuecomment-191596685
Created two pull requests as follow-up
#1178 Remove SimpleTransportPlugin and configuration and
#1179 Decommissioning SimpleTransportPlugin and
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/1173#issuecomment-191419837
Seems good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1173#issuecomment-191407577
Looks good to me. The test failures look unrelated to this. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54772909
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainClientCallbackHandler.java
---
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54769352
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslServerCallbackHandler.java
---
@@ -0,0 +1,77 @@
+package
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54749129
--- Diff: conf/defaults.yaml ---
@@ -39,7 +39,7 @@ storm.exhibitor.port: 8080
storm.exhibitor.poll.uripath: "/exhibitor/v1/cluster/list"
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54740640
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainSaslTransportPlugin.java
---
@@ -0,0 +1,69 @@
+/**
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54736725
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainClientCallbackHandler.java
---
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1173#issuecomment-191261944
Overall it looks fairly good, but you have a problem with RAT somewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54728926
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/SaslPlainServer.java ---
@@ -0,0 +1,154 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54727990
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslClientCallbackHandler.java
---
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54728782
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainSaslTransportPlugin.java
---
@@ -0,0 +1,69 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54728326
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslServerCallbackHandler.java
---
@@ -0,0 +1,77 @@
+package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54728287
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslServerCallbackHandler.java
---
@@ -0,0 +1,77 @@
+package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54727772
--- Diff: conf/defaults.yaml ---
@@ -39,7 +39,7 @@ storm.exhibitor.port: 8080
storm.exhibitor.poll.uripath: "/exhibitor/v1/cluster/list"
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54689200
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainSaslTransportPlugin.java
---
@@ -0,0 +1,69 @@
+/**
+ * Licensed to
GitHub user kishorvpatil reopened a pull request:
https://github.com/apache/storm/pull/1173
[STORM-1469] Adding Plain Sasl Transport Plugin
Since `org.apache.storm.security.auth.SimpleTransportPlugin` creates
`TFramedTransport` with maxBufferSize, but that conflicts with serialized
Github user kishorvpatil closed the pull request at:
https://github.com/apache/storm/pull/1173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/1173#issuecomment-190969675
@d2r That's right. The `SaslPlainServer` is implementation borrowed from
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/1173#issuecomment-190954323
@kishorvpatil Some of this looks like borrowed code that is not tailored
specifically to storm. Is that the case?
---
If your project is set up for it, you can reply to
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54651672
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/SaslPlainServer.java ---
@@ -0,0 +1,154 @@
+/**
+ * Licensed to the Apache Software
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54651550
--- Diff: conf/defaults.yaml ---
@@ -39,7 +39,7 @@ storm.exhibitor.port: 8080
storm.exhibitor.poll.uripath: "/exhibitor/v1/cluster/list"
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54651499
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/SaslPlainServer.java ---
@@ -0,0 +1,154 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54651434
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainServerCallbackHandler.java
---
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54651338
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainServerCallbackHandler.java
---
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54651204
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainServerCallbackHandler.java
---
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54651160
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainServerCallbackHandler.java
---
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54651094
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainSaslTransportPlugin.java
---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54650921
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainClientCallbackHandler.java
---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54650134
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainClientCallbackHandler.java
---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54650057
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainClientCallbackHandler.java
---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54649974
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainClientCallbackHandler.java
---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1173#discussion_r54649628
--- Diff: conf/defaults.yaml ---
@@ -39,7 +39,7 @@ storm.exhibitor.port: 8080
storm.exhibitor.poll.uripath: "/exhibitor/v1/cluster/list"
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/1173
[STORM-1469] Adding Plain Sasl Transport Plugin
Since `org.apache.storm.security.auth.SimpleTransportPlugin` creates
`TFramedTransport` with maxBufferSize, but that conflicts with serialized
35 matches
Mail list logo
