[GitHub] storm pull request: [STORM-529] Send fail(tup) when BasicBolt proc...

2014-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [STORM-529] Send fail(tup) when BasicBolt proc...

2014-10-16 Thread itaifrenkel
Github user itaifrenkel commented on the pull request: https://github.com/apache/storm/pull/291#issuecomment-59323312 ok. please just note that there are 3 files to change and I only changed 2 of them. I cannot tell why was the third file diverted from the others. It looks like a

[GitHub] storm pull request: [STORM-529] Send fail(tup) when BasicBolt proc...

2014-10-16 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/291#issuecomment-59346967 Looks good to me. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-529] Send fail(tup) when BasicBolt proc...

2014-10-15 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/291#issuecomment-59222813 @itaifrenkel Sorry for the long silence. We have been battling a fire here with all hands on deck. I don't see much of a reason for this to wait on STORM-528. You made

[GitHub] storm pull request: [STORM-529] Send fail(tup) when BasicBolt proc...

2014-10-15 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/291#issuecomment-59226497 I am +1 for this change. The code looks to do as expected, and everything runs well. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: [STORM-529] Send fail(tup) when BasicBolt proc...

2014-10-11 Thread itaifrenkel
GitHub user itaifrenkel opened a pull request: https://github.com/apache/storm/pull/291 [STORM-529] Send fail(tup) when BasicBolt process throws Exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/forter/storm