[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...

2014-11-14 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/302#issuecomment-63134572 @clockfly is it OK to merge this code in? I am happy to file a new JIRA for rethinking how we do metrics in storm, if you think that would be helpful. --- If your

[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...

2014-11-14 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/302#issuecomment-63138277 @revans2 I think we can merge this and open a JIRA for discussing changing the metrics infrastructure. --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...

2014-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/302#issuecomment-61989690 The metrics system is very generic, and not that complex. Essentially it sets up a timer that will periodically call getValueAndReset on an instance of IMetric. These

[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...

2014-11-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/302#issuecomment-61722105 Btw, I think it's amazing to have connection / transmitted status metric. :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...

2014-10-24 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/302 [STORM-533] Added in client and server IConnection metrics. You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm