[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-15 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121808744 @HeartSaVioR Thanks. I have created a new PR(https://github.com/apache/storm/pull/635) for 0.9.x-branch. Can this be merged into the apache branch now? --- If your pro

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-15 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121620839 @vesense Agreed on not merging to master unless we confirm that 0.10.0 and / or 0.11.0 have this issue. But, at least this should be targeted to 0.9.x-br

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121473865 @HeartSaVioR @tedxia This PR is for branch 0.9.x. 0.9.x is very different from 0.10.x and master, so when we go the cherry-pick there are a lot of conflicts. In branch 0.

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121473131 @miguno Sorry I took so long to respond. Like @tpiscitell already explained, this problem are not solved by STORM-586 and STORM-511. --- If your project is set up for i

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread 2new
Github user 2new commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121215831 Faced this issue with 0.9.5. Is this patch going to be merged in the short term? --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread mvalleavila
Github user mvalleavila commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121189676 We are reproducing the issue too, +1 Thx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121188995 In branch 0.10.0, the failed tuple has been managered by ExponentialBackoffMsgRetryManager, should we also make this change to 0.10.0 --- If your project is set up for i

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread ellull
Github user ellull commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121180650 We are also facing this issue, so +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-13 Thread alexsobrino
Github user alexsobrino commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121146615 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121066991 @vesense Could you make a pull request based on master branch? We can cherry-pick to other branches (for example, 0.10.x-branch, 0.9.x-branch) if we want.

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-13 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-120979666 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-10 Thread slora
Github user slora commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-120419097 Faced this issue with 0.9.4 and 0.9.5. Thx!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-10 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-120415203 @slora which version of storm are you using --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-10 Thread slora
Github user slora commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-120259980 I think we are facing this issue too. Is this patch going to be merged in the short term? Thx!! --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-04-20 Thread tpiscitell
Github user tpiscitell commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-94448772 @miguno I don't think either of those JIRAs fixed this issue. The problem here is that PartitionManager.fill() will always attempt to fetch any failed tuples first:

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-04-17 Thread miguno
Github user miguno commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-94007128 @vesense As [I said in the JIRA ticket](https://issues.apache.org/jira/browse/STORM-643?focusedCommentId=14494138&page=com.atlassian.jira.plugin.system.issuetabpanels:commen

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-03-12 Thread 2new
Github user 2new commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-78835043 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-02-26 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-76148389 @ptgoetz can you please review this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-02-24 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-75902724 Hi Michael, Thank you for your improvement. It would be better to skip all the outdated failed offsets in one step and I have extended the pull request.

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-02-23 Thread pershyn
Github user pershyn commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-75567762 Hi Xin, Thank you for the good finding and patch. I have applied proposed patch on pure storm-0.9.3 branch, deployed and testet, and indeed it seems to fi