Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-115269553
@tedxia I responded on your pull request #600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-115465087
@revans2 thanks for your replay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-115080809
With this patch, there are a lot of ClassNotFoundException when nimbus or
ui load Plugins such as AutoHdfs, what can we do to fix this.
---
If your project is set up for
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-109301657
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-109056014
Thank you @ptgoetz. The changes worked. And Jetty is shaded now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-109058294
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-109057662
Thanks @kishorvpatil!
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-109043828
I tried What @Parth-Brahmbhatt suggested to successfully build it. Testing
it now.
---
If your project is set up for it, you can reply to this email and have your
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-108990802
@kishorvpatil what issues did you run into when you shaded Jetty?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-108991541
@ptgoetz my problem with that is the distribution mechanism is different
for external from what it is for storm proper. Say I create a topology jar
with storm-hdfs in
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-108989857
@Parth-Brahmbhatt Primarily, anything that's getting directly called from
withing clojure is hard to shade. Hence (disruptor, jetty..) etc are not
shaded. As such
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-108990526
I agree with @Parth-Brahmbhatt. I think for components in /external we
should use the use the shaded classes in storm-core instead of manually adding
the dependency.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-108998003
@revans2 Good point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-109041007
@kishorvpatil I can't reproduce it. What does your shade config for jetty
look like?
Here are the sections I added to test:
The include:
```xml
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/577
[STORM-848] Shade external dependencies
Shading following dependencies:
org.apache.httpcomponents:http*
org.apache.zookeeper:zookeeper
org.apache.curator:*
com.twitter:carbonite
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-108971727
Can we also shade jetty? Also why there are new dependency on some
connectors.
---
If your project is set up for it, you can reply to this email and have your
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-109023252
@ptgoetz I get following exceptions when I try to shade Jetty
```Console
Compiling storm.starter.clj.word-count to
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/577#issuecomment-109025180
can you try adding following to the shade-plugin part. See
http://maven.apache.org/plugins/maven-shade-plugin/examples/includes-excludes.html
for a full
19 matches
Mail list logo
