Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146880374
@jerrypeng Technically with one +1 from a committer and 24 hours we can
merge this in. But this is a large change so I am glad to see more people
looking at it. I'll
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146880546
@revans2 Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146875059
I have two +1s now, can we merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146895509
@jerrypeng I merged this into master. Looking at the sub tasks for
STORM-893, this looked more like STORM-894.
---
If your project is set up for it, you can reply to
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146692455
Nice work! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41366483
--- Diff:
storm-core/src/jvm/backtype/storm/networktopography/DNSToSwitchMapping.java ---
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache Software
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41366160
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java
---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41366711
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -438,6 +451,35 @@ public SupervisorDetails getSupervisorById(String
nodeId) {
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41412262
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -438,6 +451,35 @@ public SupervisorDetails getSupervisorById(String
nodeId) {
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41409816
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java
---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41410090
--- Diff:
storm-core/src/jvm/backtype/storm/networktopography/DNSToSwitchMapping.java ---
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146266179
@erikdw thank you for your review. I reformated some of the files based on
your suggestions
---
If your project is set up for it, you can reply to this email and
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41283265
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -0,0 +1,478 @@
+/**
+ * Licensed to the
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41347393
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -0,0 +1,478 @@
+/**
+ * Licensed to the
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41347451
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -18,10 +18,7 @@
package backtype.storm.utils;
import
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146066442
@zhuoliu Thanks for your review. I think just push a commit that I think
address all your comments
---
If your project is set up for it, you can reply to this email
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41347349
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -0,0 +1,478 @@
+/**
+ * Licensed to the
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41283467
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -0,0 +1,478 @@
+/**
+ * Licensed to the
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41285663
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -18,10 +18,7 @@
package backtype.storm.utils;
import backtype.storm.Config;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41087614
--- Diff:
storm-core/src/jvm/backtype/storm/networktopography/DefaultRackDNSToSwitchMapping.java
---
@@ -0,0 +1,39 @@
+package
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-145253628
@jerrypeng Just two more issues, both of which re relatively minor. After
them I am +1 for merging this in. Then hopefully development work on RAS can
move forward in
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41087631
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -0,0 +1,478 @@
+/**
+ * Licensed to the
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-145261204
@revans2 Thanks for your review again! I just push a commit that contains
those revisions you suggested
---
If your project is set up for it, you can reply to this
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-145155422
@knusbaum
@rfarivar
@zhuoliu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-145152237
@revans2 Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-145152436
Done making modifications based on comments. Can I get some more reviews
please
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40838180
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +95,302 @@ public StormTopology getTopology() {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40838906
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java
---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40838543
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -0,0 +1,152 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40838272
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +95,302 @@ public StormTopology getTopology() {
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-144514012
@jerrypeng for the most part the code looks really good. I would mostly
just like to see a lot of the debug logging turned into LOG.debug instead of
LOG.info
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40838571
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -0,0 +1,152 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40838121
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +95,302 @@ public StormTopology getTopology() {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40838824
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceUtils.java ---
@@ -0,0 +1,117 @@
+package backtype.storm.scheduler.resource;
+
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40838769
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceUtils.java ---
@@ -0,0 +1,117 @@
+package backtype.storm.scheduler.resource;
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40849297
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +95,302 @@ public StormTopology getTopology() {
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40849422
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +95,302 @@ public StormTopology getTopology() {
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40850487
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceUtils.java ---
@@ -0,0 +1,117 @@
+package backtype.storm.scheduler.resource;
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40850542
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceUtils.java ---
@@ -0,0 +1,117 @@
+package backtype.storm.scheduler.resource;
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40849279
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +95,302 @@ public StormTopology getTopology() {
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40849301
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +95,302 @@ public StormTopology getTopology() {
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40849130
--- Diff:
storm-core/src/jvm/backtype/storm/networktopography/AbstractDNSToSwitchMapping.java
---
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40850307
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -0,0 +1,152 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40848979
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -442,4 +446,35 @@ public static String submitJar(Map conf, String
localJar,
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40850849
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java
---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40849566
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -0,0 +1,152 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-144451299
upmerged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-144111799
@HeartSaVioR
@revans2
Can I get a review for my PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40732961
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -442,4 +444,36 @@ public static String submitJar(Map conf, String
localJar,
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40734280
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -31,41 +42,47 @@
StormTopology topology;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40732244
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +96,304 @@ public StormTopology getTopology() {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40731979
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -31,41 +42,47 @@
StormTopology topology;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40730552
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -442,4 +444,36 @@ public static String submitJar(Map conf, String
localJar,
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40730558
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -167,6 +167,16 @@
public static final Object STORM_CLUSTER_MODE_SCHEMA =
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40732462
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -442,4 +444,36 @@ public static String submitJar(Map conf, String
localJar,
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40732321
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +96,304 @@ public StormTopology getTopology() {
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40734496
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +96,304 @@ public StormTopology getTopology() {
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40734516
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +96,304 @@ public StormTopology getTopology() {
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/746
[STORM-893] Resource Aware Scheduling
I have created a initial open source implementation of the Resource Aware
Scheduler as described in the paper I published:
60 matches
Mail list logo
