Github user lyonbrw closed the pull request at:
https://github.com/apache/storm/pull/637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user lyonbrw commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122130478
Will do. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122117993
@lyonbrw
I cherry-picked your efforts into master now. Would you close this PR?
---
If your project is set up for it, you can reply to this email and have your
r
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122100673
OK, confirmed that all things fixed. +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user lyonbrw commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122099783
Indentation fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122099913
@lyonbrw
Actually I recommended you to make new branch before do some works.
I can cherry-pick your commits into master, so let me handle it for now.
---
If
Github user lyonbrw commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122097348
Apologize for the merge commit. What is the proper way to remove it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122090455
@lyonbrw
Indentation is still broken. Please compare parseInputStream()'s indent
level to other methods.
Btw, could you get rid of merge commit from PR i
Github user lyonbrw commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122088647
Just saw that redundant close() function before you commented. My bad. ;)
Thanks. Corrected both, build in progress.
---
If your project is set up for it, you can reply
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/637#discussion_r34835109
--- Diff:
external/flux/flux-core/src/main/java/org/apache/storm/flux/parser/FluxParser.java
---
@@ -44,40 +44,47 @@ private FluxParser(){}
// TO
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/637#discussion_r34834409
--- Diff:
external/flux/flux-core/src/main/java/org/apache/storm/flux/parser/FluxParser.java
---
@@ -44,40 +44,47 @@ private FluxParser(){}
// TO
11 matches
Mail list logo
