[GitHub] storm pull request: Refactored TimeCacheMap to extend RotatingMap.

2015-08-13 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/682#issuecomment-130863117 I'm in favor of using RotatingMap to implement TimeCacheMap, but I'd rather have a RotatingMap as a member of TimeCacheMap than as a superclass. --- If your project is

[GitHub] storm pull request: Refactored TimeCacheMap to extend RotatingMap.

2015-08-13 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/682#issuecomment-130860541 @ddebree Thanks. I should have mentioned it, but we also include the issue name in the title of our pull requests by convention. ``` [STORM-990] Refactored TimeCa

[GitHub] storm pull request: Refactored TimeCacheMap to extend RotatingMap.

2015-08-13 Thread ddebree
Github user ddebree commented on the pull request: https://github.com/apache/storm/pull/682#issuecomment-130850289 Issue raised: https://issues.apache.org/jira/browse/STORM-990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] storm pull request: Refactored TimeCacheMap to extend RotatingMap.

2015-08-13 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/682#issuecomment-130823894 For large changes like this and #683, Please file a jira at https://issues.apache.org/jira/browse/STORM/ --- If your project is set up for it, you can reply to this ema

[GitHub] storm pull request: Refactored TimeCacheMap to extend RotatingMap.

2015-08-13 Thread ddebree
GitHub user ddebree opened a pull request: https://github.com/apache/storm/pull/682 Refactored TimeCacheMap to extend RotatingMap. This should allow current users of the TimeCacheMap to progressively migrate off the deprecated TimeCacheMap to the simpler RotatingMap. This also