Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-154439175
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-154205971
I just tried to build with this and we need to upmerge because filght.bash
has been added in recently.
---
If your project is set up for it, you can reply to this email
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-154209788
Upmerged and squashed to a single commit @revans2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153887348
@dossett Yes. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153798617
@revans2 @ptgoetz @redsanket Are you still +1 on this change? I added the
small travis step of printing file names with failed licenses since your vote.
---
If your
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153818109
Yes I am +1. It looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user dossett opened a pull request:
https://github.com/apache/storm/pull/846
STORM-1161: Add License headers and add rat checks to builds
This moves Apache Rat out of the release profile and into the standard
build process. It will add a slight amount of time to builds for
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153390872
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153458658
@dossett none of us have permission for those files, in fact they are
probably gone by now. Travis only saves what was output to the log. You could
put in something in
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153457771
Travis says that storm-hive failed the rat check. Can someone show me the
contents of
"/home/travis/build/apache/storm/external/storm-hive/target/rat.txt" ?
---
If
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153479198
I found the storm-hive issue. The remaining java7 failure appears
unrelated to these changes and java8 build was successful.
---
If your project is set up for it, you
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153472536
Thanks @revans2, I'm learning a lot today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
13 matches
Mail list logo
