Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-164794521
Thanks @hmcl merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/930
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-164766816
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-164674438
+1
I have a question, does this change affect travis ci since I don't see ci
scripts changed.
---
If your project is set up for it, you can reply to this email an
Github user rfarivar commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-164613029
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-164586572
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-164316721
@revans2 can you take a look at as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-163382318
+1. @hmcl can you upmerge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-163363035
Currently, by default no Java or Clojure integration tests get run when
executing `mvn clean install`. Only unit tests get executed. The user must run
maven with one of the
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/930#issuecomment-162757495
@hmcl can you amend the commit message to reflect STORM-1179. Create Maven
Profiles for Integration Tests.
---
If your project is set up for it, you can reply to this e
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/930
Storm 1179
This patch has 3 commits.
- POM changes implementing profiles to separate integration tests and unit
tests
- Two separate commits that illustrate how to migrate existing tests
curr
11 matches
Mail list logo
