Github user haohui commented on the pull request:
https://github.com/apache/storm/pull/993#issuecomment-170099926
The test passed locally. Committing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user haohui closed the pull request at:
https://github.com/apache/storm/pull/993
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user haohui commented on the pull request:
https://github.com/apache/storm/pull/993#issuecomment-170101211
Merged in 1f1ba77be849e50cdc09fcfe08dcec8f4984b4f9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/993#issuecomment-169539886
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user haohui opened a pull request:
https://github.com/apache/storm/pull/993
STORM-1404. Mockito test failures in storm-kafka.
This PR fixes the failed test reported in STORM-1404. It replaces the
unreliable `Thread.sleep()` with comprehensive mocking to make sure the tests
