[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1084 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-18 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-185908580 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-16 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-185038798 @harshach Upmerged and resolved conflicts. We do not need this on 1.x. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-16 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-185018716 @satishd can you upmerge this and also open another PR for 1.x-branch if we want this there as well. Thanks. --- If your project is set up for it, you can reply to

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-181485037 I just did some poking around and it looks like these failures are likely unrelated. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-181484415 The code looks fine to me, but for some reason nimbus-test is failing fairly consistently. Also storm-hdfs is very unstable right now. --- If your project is set up

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1084#discussion_r52034936 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -577,11 +577,11 @@ (defserverfn mk-worker [conf shared-mq-context

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-180411794 @satishd Is it happening with all topologies ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-180478178 @arunmahadevan Right, this issue happens with all topologies. There is nothing specific about the mentioned topology in JIRA. --- If your project is set up for it, you

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread satishd
GitHub user satishd opened a pull request: https://github.com/apache/storm/pull/1084 STORM-1516 Fixed issue in writing pids with distributed cluster mode. Whenever a topology is submitted, it creates respective workers on supervisor/s. These worker pids are stored as files in

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1084#discussion_r52013516 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -577,11 +577,11 @@ (defserverfn mk-worker [conf shared-mq-context

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1084#discussion_r52015347 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -577,11 +577,11 @@ (defserverfn mk-worker [conf shared-mq-context storm-id

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1084#discussion_r52015690 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -577,11 +577,11 @@ (defserverfn mk-worker [conf shared-mq-context storm-id

[GitHub] storm pull request: STORM-1516 Fixed issue in writing pids with di...

2016-02-05 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1084#issuecomment-180695960 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature