Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1107#issuecomment-197358536
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srdo commented on the pull request:
https://github.com/apache/storm/pull/1107#issuecomment-197016989
The test failure looks unrelated to this PR, was also happening on
1.x-branch https://travis-ci.org/apache/storm/jobs/115948898
---
If your project is set up for it, you
Github user srdo commented on the pull request:
https://github.com/apache/storm/pull/1107#issuecomment-190949609
@revans2 Sure, I'll leave this open then. Here's the master version of this
PR https://github.com/apache/storm/pull/1174
---
If your project is set up for it, you can
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1107#issuecomment-190905862
@srdo If you want to get the changes into 1.x keep this around. master and
1.x have diverged enough that it is not a simple sherry-pick any more for this
part of the
Github user srdo commented on the pull request:
https://github.com/apache/storm/pull/1107#issuecomment-190881185
Great. I'll make another PR when I've made these changes on master. Should
I close this one?
---
If your project is set up for it, you can reply to this email and have
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1107#issuecomment-190858491
@srdo Sorry I have been really behind on reviews. The code and the concept
seem sound. I have not thought through all of the implications of this, but as
of now I am
Github user srdo commented on the pull request:
https://github.com/apache/storm/pull/1107#issuecomment-190826744
Anyone have any feedback on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1107
STORM-1549: Add support for resetting tuple timeout from bolts via the
OutputCollector
See https://issues.apache.org/jira/browse/STORM-1549.
Other than implementing tuple timeout reset, I
