[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2016-03-07 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/250#issuecomment-193481184 @RaghavendraNandagopal Closing this. We still like the functionality, so free to reopen if you have time to address the comments. --- If your project is set up

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2015-10-08 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/250#discussion_r41551583 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -108,7 +108,15 @@ */ public static final String

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2015-10-08 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/250#issuecomment-146651595 @RaghavendraNandagopal , It has been a while, so just checking: Are we still looking to merge this code in? --- If your project is set up for it, you can reply to this

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2015-10-08 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/250#discussion_r41551714 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -66,8 +67,14 @@ private AtomicLong flushCheckTimer; private int

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2015-02-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/250#issuecomment-76214103 @RaghavendraNandagopal pinging for an upmerge to master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2015-01-09 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/250#issuecomment-69367006 @RaghavendraNandagopal any update on this? Don't want to lose this great work. If you are too busy I can try and upmerge it myself. --- If your project is set up for

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2015-01-09 Thread RaghavendraNandagopal
Github user RaghavendraNandagopal commented on the pull request: https://github.com/apache/storm/pull/250#issuecomment-69374819 Hi Bobby, Sorry for getting it late. I will definitely complete it within 3-4 days from now. Hopefully by Tuesday I will send a new pull request.

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2014-11-18 Thread RaghavendraNandagopal
Github user RaghavendraNandagopal commented on the pull request: https://github.com/apache/storm/pull/250#issuecomment-63523530 Hi Bobby, Sorry for the delay. I will work on the comments and close it ASAP. Thanks, Raghavendra Nandagopal --- If your project is set

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2014-11-18 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/250#issuecomment-63524216 Not a problem it is great work, I would like to see it in. Also note that security has been merged into master so if you could update your pull request to master that

[GitHub] storm pull request: STORM-430: Allow netty SASL to support encrypt...

2014-11-18 Thread RaghavendraNandagopal
Github user RaghavendraNandagopal commented on the pull request: https://github.com/apache/storm/pull/250#issuecomment-63528271 Sure, I will work on master branch. Thanks, Raghavendra Nandagopal --- If your project is set up for it, you can reply to this email and have