[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2016-05-10 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-218075001 Guys, follow up discussion is happening on #1406. Can you let me know your feedback there? --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2016-05-06 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-217363373 Because we need average length of queue average over each time window. If you look at the LatencyStatAndMetric, it does exactly that. I record the queue

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2016-05-05 Thread dsKarthick
Github user dsKarthick commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-217241771 @abhishekagarwal87 I am excited to see your screenshot as well. Also, I am curious as why you chose to use

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2016-05-05 Thread erikdw
Github user erikdw commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-217228874 @abhishekagarwal87 : awesome news! Any way you can post a screenshot of the UI you are currently proposing? At least please do so with the PR when you send it.

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2016-05-05 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-217110521 I am preparing a patch for publishing in-backlog (receive-queue) and out-backlog (send-queue). I can see the average value of these metrics on UI over each

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2016-05-04 Thread erikdw
Github user erikdw commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-217026345 @knusbaum : I see you closed this. Are you planning to open a new PR for publishing these stats? It would be a big help to us, we often wonder at various behaviors we

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2016-03-07 Thread knusbaum
Github user knusbaum closed the pull request at: https://github.com/apache/storm/pull/236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2015-06-23 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-114682609 Hi @knusbaum, it has been a while, and it looks like this needs an up-merge again. It might also be good to remove changes from the Thrift-generated code that result in

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2015-02-06 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-7327 This is ready for another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2015-02-05 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-73051461 Do we still want this? Yes, I think this would be a tremendous help to users while debugging slowness issues. --- If your project is set up for it, you can reply to

[GitHub] storm pull request: STORM-433: Give users visibility to the depth ...

2015-02-04 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/236#issuecomment-72969470 @nathanmarz, @revans2, @d2r Do we still want this? If so I'll upmerge and fix all the problems: 1. easy, I'll take care of this. 2. I can also monitor the