Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/279#issuecomment-61831975
@clockfly this patch doesn't work. running this mvn clean install
-DSTORM_TEST_TIMEOUT_MS=3
(let [timeout (System/getProperty STORM_TEST_TIMEOUT_MS)]
the
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/279#issuecomment-61885540
@ptgoetz @harshach @clockfly
I did confused about it at that time. Sorry about my mistake. ;( I'll
update it and post new PR.
Regarding revert plan, actually
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/279#issuecomment-61893230
I re-read my comments, and I found I've mistaken with talking to @ptgoetz .
Actually I prefer JVM property, not system environment. Maybe I was
confusing about
Github user curtisallen commented on the pull request:
https://github.com/apache/storm/pull/279#issuecomment-59975061
Any chance this can make it into v0.9.3-rc2?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/279#discussion_r18803151
--- Diff: DEVELOPER.md ---
@@ -229,6 +229,9 @@ The following commands must be run from the top-level
directory.
# Build the code and run the
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/279#issuecomment-57910263
@HeartSaVioR overall this looks good to me and works as expected. Please
add a note to DEVELOPER.md under Build the code and run the tests on
setting the
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/279#issuecomment-57912017
@harshach I've reflected your suggestion. Thanks for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
