[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-12 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/415#issuecomment-74118053 fixed the doc. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-12 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/415#issuecomment-74108012 @ptgoetz @revans2 Bobby already gave a +1 from previous PR. This new PR is an upmerge without any code changes. Can you please take a look. --- If your project is set

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/415#discussion_r24597644 --- Diff: STORM-UI-REST-API.md --- @@ -630,6 +642,31 @@ Rebalances a topology. |--||-| |id |String (required)|

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/415#issuecomment-74114183 +1 The typo fix is a non-code change so I'm fine with including that. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-03 Thread harshach
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/415 STORM-581. Add rebalance params to Storm REST API. You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/incubator-storm STORM-581-V1

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/370#issuecomment-72748703 closing this PR. https://github.com/apache/storm/pull/415 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/370#issuecomment-72736581 Please hold merging this in. I'll send a new PR. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-01-23 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/370#issuecomment-71254799 +1 the code looks good. It needs to be upmerged, but other then that it looks fine. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-01-03 Thread harshach
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/370 STORM-581. Add rebalance params to Storm REST API. This PR also fixes the POST operations redirection. You can merge this pull request into a Git repository by running: $ git pull