[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

2015-01-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/369#issuecomment-68886875 +1 looks fine to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

2014-12-29 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/369 STORM-613: Fix wrong getOffset return value When judge getOffset return value, use 0 not NO_OFFSET as invalid offset return value. You can merge this pull request into a Git repository by running:

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

2014-12-29 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/369#issuecomment-68267623 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

2014-12-29 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/369#issuecomment-68314022 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature