Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-202250432
Great work @satishd . Merged into 1.x and master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1072
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-201992895
@harshach Raised https://github.com/apache/storm/pull/1263 on 1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-201904903
@harshach Upmerged and refactored HBase put APIs with recent hbase version
upgrade in the master branch.
---
If your project is set up for it, you can reply to this ema
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-201882512
@satishd
"[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project storm-hbase: Compilation failure:
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-201879790
@satishd can you open a PR against 1.x-branch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-201194400
+1 for merging this. If we are including this in 1.0, its better to update
the trident api docs as well in 1.0.
---
If your project is set up for it, you can repl
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-201139676
@arunmahadevan looks like all comments are addressed. Can you please take a
look.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57272190
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57232035
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-200349889
- [STORM-1651](https://issues.apache.org/jira/browse/STORM-1651) is created
for adding event time based support in trident windowing.
- [STORM-1652](https://issues.ap
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57158337
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/builtin/Debug.java ---
@@ -40,7 +42,7 @@ public Debug(String name) {
@Override
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-200303590
1. The event time based windows are not exposed via trident, can you file a
follow up JIRA ?
2. Trident api docs needs to be updated with windowing apis.
3.
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143584
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/strategy/WindowStrategyFactory.java
---
@@ -0,0 +1,60 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143565
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java
---
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache S
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143513
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/WindowTridentProcessor.java
---
@@ -0,0 +1,265 @@
+/**
+ * Licensed to the Apac
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143286
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/builtin/Debug.java ---
@@ -40,7 +42,7 @@ public Debug(String name) {
@Ove
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143253
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143259
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143154
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStoreFactory.java
---
@@ -0,0 +1,54 @@
+/**
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143240
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143217
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143245
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143211
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143185
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143236
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143182
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143268
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143132
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Lic
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57113443
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57112111
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregator agg
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57111959
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregator agg
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57111677
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentWindowingInmemoryStoreTopology.java
---
@@ -0,0 +1,133 @@
+/**
+ * L
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57111526
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122 @@
+/**
+ * Lice
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57110471
--- Diff: examples/storm-starter/pom.xml ---
@@ -149,6 +152,11 @@
storm-hdfs
${project.version}
+
+ org.
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769644
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769635
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0 (the
* "
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769652
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/builtin/Debug.java ---
@@ -40,7 +42,7 @@ public Debug(String name) {
@Ove
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769629
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Lic
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769646
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,155 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769600
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122 @@
+/**
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769622
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentWindowingInmemoryStoreTopology.java
---
@@ -0,0 +1,133 @@
+/**
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769608
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122 @@
+/**
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769596
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122 @@
+/**
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769621
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentWindowingInmemoryStoreTopology.java
---
@@ -0,0 +1,133 @@
+/**
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769598
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122 @@
+/**
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769589
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122 @@
+/**
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769591
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122 @@
+/**
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769587
--- Diff: examples/storm-starter/pom.xml ---
@@ -177,6 +185,36 @@
storm-redis
${project.version}
+
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769581
--- Diff: examples/storm-starter/pom.xml ---
@@ -149,6 +152,11 @@
storm-hdfs
${project.version}
+
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769585
--- Diff: examples/storm-starter/pom.xml ---
@@ -177,6 +185,36 @@
storm-redis
${project.version}
+
+
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769580
--- Diff: examples/storm-starter/pom.xml ---
@@ -31,10 +31,13 @@
storm-starter
- UTF-8
-
- provided
+
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-197175210
@harshach I haven't reviewed the code yet, plan to do that within a couple
of days.
---
If your project is set up for it, you can reply to this email and have you
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-196884101
+1. will wait for @arunmahadevan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56130662
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,169 @@ public Stream aggregate(Fields inputFields,
ReducerAggregator agg
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-196685078
Triggered results piggyback on the incoming tuples to send those results to
the downstream. When there are no batch tuples then these triggers would wait.
Filed [STORM-1
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-196317380
@arunmahadevan What is the batch emit interval in your topology
configuration? Each triggered result is emitted as part of the nearest batch
completed. Trident runs in b
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-196279990
Haven't gone through the code in great detail, but when I ran a simple
topology with a tumbling time window of 3 secs,
- If the spout emits a batch and sle
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55989920
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,169 @@ public Stream aggregate(Fields inputFields,
ReducerAggregat
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55941142
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStoreFactory.java
---
@@ -0,0 +1,51 @@
+/**
+ * Li
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55941127
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55934087
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStoreFactory.java
---
@@ -0,0 +1,51 @@
+/**
+ * Lic
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55933892
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentWindowingInmemoryStoreTopology.java
---
@@ -0,0 +1,134 @@
+/**
+ * L
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55932588
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/InMemoryWindowsStoreFactory.java
---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55932046
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/AbstractTridentWindowManager.java
---
@@ -0,0 +1,241 @@
+/**
+ * Licensed to the Apac
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55931828
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/builtin/Debug.java ---
@@ -40,7 +42,7 @@ public Debug(String name) {
@Override
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55931797
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-195847392
Thanks @satishd . Sorry for taking long time to review. I've few minor
nits. Can you please address those.
---
If your project is set up for it, you can reply to this
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930607
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/WindowsStore.java ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Found
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930541
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/InMemoryWindowsStoreFactory.java
---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apach
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930526
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/AbstractTridentWindowManager.java
---
@@ -0,0 +1,241 @@
+/**
+ * Licensed to the Apa
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930514
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/builtin/Debug.java ---
@@ -40,7 +42,7 @@ public Debug(String name) {
@Override
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930477
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStoreFactory.java
---
@@ -0,0 +1,51 @@
+/**
+ * Li
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930467
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930433
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930422
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentWindowingInmemoryStoreTopology.java
---
@@ -0,0 +1,134 @@
+/**
+ *
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55930081
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentWindowingInmemoryStoreTopology.java
---
@@ -0,0 +1,134 @@
+/**
+ *
77 matches
Mail list logo
