Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-95336419
+1 great job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90778496
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/509
Storm 748 - Package Multi-Lang scripts so they don't have to be duplicated
This moves storm's multi-lang components to a single location so they can
be referenced from, rather than copied to other
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90279252
Commenting to trigger JIRA sync. Ignore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90317604
@ptgoetz Yes, you're right. I didn't think about language which needs
compilation.
Thanks for clarification.
---
If your project is set up for it, you can reply
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90296950
Your approach is great!
Btw, since each language contains only one source file, how about
aggregating these into multilang module? pom.xml seems to be duplicated,
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90306940
@HeartSaVioR Thanks for the feedback. I'm open to either approach...
My thought behind keeping them separate was that some languages may require
compilation (e.g.
