[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...

2015-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/711 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...

2015-09-01 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/711 STORM-996: netty-unit-tests/test-batch demonstrates out-of-order delivery Netty calls notifyInterestChanged which causes a race condition in flushMessages. You can merge this pull request into a

[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...

2015-09-01 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/711#issuecomment-136813085 +1 This seems to fix the issue. I ran test-batch ~50 times without a failure. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...

2015-09-01 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/711#issuecomment-136840377 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...

2015-09-01 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/711#issuecomment-136884363 +1 Nice work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...

2015-09-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/711#issuecomment-136859814 +1 Great! Missed StormClientHandler so there's only one thread which accesses to Client at any time. --- If your project is set up for it, you can reply to this