[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-16 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-219623148 cc. @ptgoetz @harshach Could you review this as well? Just want to check we're OK to drop support HBase 0.9x. --- If your project is set up for it, you can reply to

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1388#issuecomment-216717573 sorry, please check https://github.com/apache/storm/pull/1395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
Github user lujinhong closed the pull request at: https://github.com/apache/storm/pull/1388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1395 storm-1726: use Put#addColumn to replace the deprecated Put#add You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm 1.x-branch Al

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1388#issuecomment-216483766 @lujinhong No you need to create your branch based on 1.x-branch in order to craft pull request against 1.x-branch. --- If your project is set up for it, you can re

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1388 storm-1726: use Put#addColumn to replace the deprecated Put#add You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm storm-hbase A

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-216474300 @lujinhong Never mind. It would be better to cherry-pick since patch is really tiny. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-216473947 @lujinhong Would you also craft pull request for 1.x-branch? I can also cherry-pick so please submit if you really don't mind. --- If your project is set up for it,

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-216473523 +1 @Parth-Brahmbhatt Would you have a plan to submit your patch for the improvement? --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-04-22 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-213647983 https://issues.apache.org/jira/browse/STORM-1726?filter=12335179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub