[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-23 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1132#issuecomment-187592967 https://github.com/apache/storm/blob/master/external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java#L250 You can add the partitions to

[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-22 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1132#issuecomment-187501380 1. when refreshFreqSecs expired, it will refresh. 2. for the second, I think it is about the task-partition mapping mechanism,is it in the clojure code of Task?

[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-21 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1132#issuecomment-187040728 I am thinking of the side effects that this change can lead to - 1. Number of tasks could be more than number of partitions - Acceptable and will be

[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-21 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1132#discussion_r53590435 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java --- @@ -85,6 +85,10 @@ public DynamicBrokersReader(Map

[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-21 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1132#issuecomment-186987218 In KafkaUtil.java, NOT_LEADER_FOR_PARTITION happend, catching the NOT_LEADER_FOR_PARTITION execption will be a good idea. This exception should be catch and

[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-21 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1132 storm-kafka : kafka-partition can not find leader in zookeeper #1132 STORM-1065. storm-kafka : kafka-partition can not find leader in zookeeper You can merge this pull request into a Git