[GitHub] storm pull request #1962: storm jdbc topology should log the jdbc connection...

2017-02-24 Thread tkuwabara789
Github user tkuwabara789 commented on a diff in the pull request: https://github.com/apache/storm/pull/1962#discussion_r103004836 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/HikariCPConnectionProvider.java --- @@ -40,6 +44,10 @@ public synchronized

[GitHub] storm pull request #1962: storm jdbc topology should log the jdbc connection...

2017-02-24 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/1962#discussion_r103002040 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/HikariCPConnectionProvider.java --- @@ -40,6 +44,10 @@ public synchronized void

[GitHub] storm pull request #1962: storm jdbc topology should log the jdbc connection...

2017-02-24 Thread tkuwabara789
Github user tkuwabara789 commented on a diff in the pull request: https://github.com/apache/storm/pull/1962#discussion_r102990972 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/HikariCPConnectionProvider.java --- @@ -40,6 +44,10 @@ public synchronized

[GitHub] storm pull request #1962: storm jdbc topology should log the jdbc connection...

2017-02-24 Thread tibkiss
Github user tibkiss commented on a diff in the pull request: https://github.com/apache/storm/pull/1962#discussion_r102898864 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/HikariCPConnectionProvider.java --- @@ -40,6 +44,10 @@ public synchronized void

[GitHub] storm pull request #1962: storm jdbc topology should log the jdbc connection...

2017-02-23 Thread tkuwabara789
GitHub user tkuwabara789 opened a pull request: https://github.com/apache/storm/pull/1962 storm jdbc topology should log the jdbc connection string to debug fa… …ilures Minor addition to expose JDBC connection string through logging in Hikari CP implementation. For