Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2261
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2261#discussion_r134778874
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareCustomStreamGrouping.java
---
@@ -20,5 +20,6 @@
import java.util.List;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2261#discussion_r134645082
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -52,25 +78,92 @@ public void prepare(WorkerTopologyContext
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2261#discussion_r134644962
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -20,30 +20,56 @@
import java.io.Serializable;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2261#discussion_r134644598
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -52,25 +78,92 @@ public void prepare(WorkerTopologyContext
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2261#discussion_r134640202
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -52,25 +78,92 @@ public void prepare(WorkerTopologyContext
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2261
STORM-2678 Improve performance of LoadAwareShuffleGrouping
* construct ring which represents distribution of tasks based on load
* chooseTasks() just accesses the ring sequentially
*
