Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2428
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r155916418
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -359,7 +356,7 @@ private Builder(Builder
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r155909342
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -359,7 +356,7 @@ private Builder(Builder
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r153035388
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -320,20 +320,17 @@ private
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r153035015
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -320,20 +320,17 @@ private Builder(Builder
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r153033776
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -320,20 +320,17 @@ private
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r151886343
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -292,17 +292,21 @@ private Builder(String
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2428
STORM-2826: Set key/value deserializer fields when using the convenience
builder methods in KafkaSpoutConfig
Builds on STORM-2825.
You can merge this pull request into a Git repository by running:
