[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2732 ---

[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-25 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2732#discussion_r197832970 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3557,6 +3570,14 @@ public ByteBuffer downloadBlobChunk(String

[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2732#discussion_r197830127 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3557,6 +3570,14 @@ public ByteBuffer downloadBlobChunk(String

[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-25 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2732#discussion_r197790334 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2672,7 +2680,12 @@ private ClusterSummary getClusterInfoImpl()

[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2732#discussion_r197608092 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3557,6 +3570,14 @@ public ByteBuffer downloadBlobChunk(String

[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2732#discussion_r197608138 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2672,7 +2680,12 @@ private ClusterSummary getClusterInfoImpl()

[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-21 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2732#discussion_r197264602 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3557,6 +3570,14 @@ public ByteBuffer downloadBlobChunk(String

[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-21 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2732#discussion_r197260303 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3557,6 +3570,14 @@ public ByteBuffer downloadBlobChunk(String

[GitHub] storm pull request #2732: STORM-3117 prevent deleting blobs while topologies...

2018-06-21 Thread agresch
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2732 STORM-3117 prevent deleting blobs while topologies still active Prevented crashing nimbus if blob is deleted during a getClusterInfo call. However, once nimbus is restarted, if there was an active