[GitHub] storm pull request #2893: STORM-3272 allow worker-launcher to delete dead sy...

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2893 ---

[GitHub] storm pull request #2893: STORM-3272 allow worker-launcher to delete dead sy...

2018-10-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/2893#discussion_r227445654 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -593,14 +593,17 @@ int recursive_delete(const char *path, int supervisor_owns_dir)

[GitHub] storm pull request #2893: STORM-3272 allow worker-launcher to delete dead sy...

2018-10-23 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2893#discussion_r227434073 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -593,14 +593,17 @@ int recursive_delete(const char *path, int

[GitHub] storm pull request #2893: STORM-3272 allow worker-launcher to delete dead sy...

2018-10-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2893#discussion_r227418284 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -593,14 +593,17 @@ int recursive_delete(const char *path, int

[GitHub] storm pull request #2893: STORM-3272 allow worker-launcher to delete dead sy...

2018-10-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/2893#discussion_r227412685 --- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c --- @@ -593,14 +593,17 @@ int recursive_delete(const char *path, int supervisor_owns_dir)

[GitHub] storm pull request #2893: STORM-3272 allow worker-launcher to delete dead sy...

2018-10-23 Thread agresch
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2893 STORM-3272 allow worker-launcher to delete dead symlinks When a topology folder contains a symlink to a missing file, the worker-launcher would not remove the symlink. This prevents force delete