Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread Alexandre Vermeerbergen
Hello Jungtaek, Reporting bugs is the least I can do to thank you guys for developing Storm :) I understand that there will be a RC4, but just FYI I have tested RC3 on a small Storm cluster with our 10+ topologies (small setup: 1 Nimbus VM, 1 Supervisor VM, 1 Zookeeper VM, Kafka Broker 1.0.0 and

[CANCELED] [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread P. Taylor Goetz
Canceling to include fix for STORM-2942. -Taylor > On Feb 6, 2018, at 4:01 PM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.2.0 (rc3) > > Full list of changes in this release: > >

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread Jungtaek Lim
Filed https://issues.apache.org/jira/browse/STORM-2943 for storm-kafka-monitor src/javadoc inclusion issue and assigned to Taylor. 2018년 2월 8일 (목) 오전 5:32, Jungtaek Lim 님이 작성: > Thanks for addressing md5/sha issue, Taylor. Verified src.tar.gz and > src.zip. > > Alexandre,

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread P. Taylor Goetz
I agree. As a heads up, I’m going to commit the the following change for 1.x and 1.1.x: --- a/storm-dist/binary/src/main/assembly/binary.xml +++ b/storm-dist/binary/src/main/assembly/binary.xml @@ -313,7 +313,7 @@ ${project.basedir}/../../external/storm-kafka-monitor/target

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread Jungtaek Lim
Thanks for addressing md5/sha issue, Taylor. Verified src.tar.gz and src.zip. Alexandre, thanks again for thoughtful verification of release. It much helped for us and I really appreciate it. Please keep up the good work. I feel what Alexandre reported is a blocker since it leads strange error

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread P. Taylor Goetz
Yes. It will be fixed. Thanks again for pointing it out. -Taylor > On Feb 7, 2018, at 2:57 PM, Alexandre Vermeerbergen > wrote: > > Hello Taylor, > > Yes same issue in Storm 1.1.0 : we have a production storm cluster > based on this release, but then we were using

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread Alexandre Vermeerbergen
Hello Taylor, Yes same issue in Storm 1.1.0 : we have a production storm cluster based on this release, but then we were using our own Kafka spout, no we weren't impacted by this packaging issue. Could the extraneous files be cleaned up from 1.2.0-final? Best regards, Alexandre Vermeerbergen

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread P. Taylor Goetz
Hi Alexandre, Thanks for the review. You’re right, the javadoc/source jars should not be there, though it looks like this has been the case for a long time and would have affected previous releases. It looks like the problem was introduced in 1.1.0. Have you seen the same issue in other 1.1.x

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread Alexandre Vermeerbergen
Hello All, I hate to be the one who always give bad news, but as a matter of facts, Storm 1.2.0 RC3 installation from binary artifacts (both apache-storm-1.2.0-src.tar.gz and apache-storm-1.2.0.zip) leads to "by default KO Kafka monitor" in Nimbus UI (which dirty exceptions in ui.log) Here's for

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread P. Taylor Goetz
Corrected. Thanks for pointing that out. -Taylor > On Feb 7, 2018, at 7:39 AM, Jungtaek Lim wrote: > > Looks like missing md5/sha for apache-storm-1.2.0-src.tar.gz as well as > apache-storm-1.2.0-src.zip. > > I'll continue verifying without that. > > 2018년 2월 7일 (수) 오전

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread Jungtaek Lim
CORRECTION: didn't check md5/sha from source targz/zip since the files are not presented. Will check again once they are available. 2018년 2월 7일 (수) 오후 10:49, Jungtaek Lim 님이 작성: > +1 (binding) > > > source > > - verify file (signature, MD5, SHA) > -- source, tar.gz : OK > --

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread Jungtaek Lim
+1 (binding) > source - verify file (signature, MD5, SHA) -- source, tar.gz : OK -- source, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - build source with JDK 7 -- source, tar.gz : OK - build source dist --

Re: [VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-07 Thread Jungtaek Lim
Looks like missing md5/sha for apache-storm-1.2.0-src.tar.gz as well as apache-storm-1.2.0-src.zip. I'll continue verifying without that. 2018년 2월 7일 (수) 오전 6:01, P. Taylor Goetz 님이 작성: > This is a call to vote on releasing Apache Storm 1.2.0 (rc3) > > Full list of changes in

[VOTE] Release Apache Storm 1.2.0 (rc3)

2018-02-06 Thread P. Taylor Goetz
This is a call to vote on releasing Apache Storm 1.2.0 (rc3) Full list of changes in this release: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.0-rc3/RELEASE_NOTES.html The tag/commit to be voted upon is v1.2.0: