[GitHub] storm issue #1756: STORM-1278: Port org.apache.storm.daemon.worker to java

Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1756 That's good to hear Robert. I will resolve the conflicts and incorporate your suggestions. Thank you for your help. --- If your project is set up for it, you can reply to this email and

[GitHub] storm issue #1756: STORM-1278: Port org.apache.storm.daemon.worker to java

Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1756 The PR is ready now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1756: STORM-1278: Port org.apache.storm.daemon.worker to...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1756#discussion_r86344854 --- Diff: storm-core/src/clj/org/apache/storm/testing.clj --- @@ -667,23 +665,18 @@ (.put "spout-emitted" (AtomicInteger. 0))

[GitHub] storm issue #1756: STORM-1278: Port org.apache.storm.daemon.worker to java

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1756 Looks great I am +1 even without the last comment I made (That code can go away when it is translated to java). But since I also contributed some of the test code changes I really would

Re: [DISCUSS] Drop features about GROUP BY, JOIN from Storm SQL Trident mode

This seems to be no other opinions, so I would go on dropping "group by" and "join" for Storm SQL Trident mode until we're ready to handle windowing on SQL semantic. - Jungtaek Lim (HeartSaVioR) 2016년 10월 22일 (토) 오전 12:23, Jungtaek Lim 님이 작성: > Yes there seems many things

[GitHub] storm issue #1748: [STORM-2103][SQL] Introduce new sql external module: stor...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1748 @vesense I manually tested that it works. Thanks for the great work! Btw, I'm seeing that only one fields are used for storing the value, but I guess some users occasionally would want

Re: How does the control flow in a Trident Topology work?

It is very confusing and i don't completely understand it all myself, but for the most part what happens, as far as I understand it, is that the master batch coordinator sends out begin batch messages to all of the spout coordinators and all the state instances saying batch X is about to begin.

[GitHub] storm issue #1679: STORM-2087: storm-kafka-client - tuples not always being ...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1679 @hmcl it has been a week, any hope of finishing the review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1758: STORM-2185: Storm Supervisor doesn't delete directories p...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1758 +1 I see that the race seems to be that if a worker is shut down after creating the directory, but before running chown on it, then we hit this situation. --- If your project is set up for it, you

[GitHub] storm issue #1759: STORM-2185: Storm Supervisor doesn't delete directories p...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1759 As a note to whoever merges this in we should merge this to 1.0.x too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1755: error log for blobstore was missing a space between strin...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1755 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1755: error log for blobstore was missing a space betwee...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1755 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1755: error log for blobstore was missing a space between strin...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1755 @erikdw Thanks, I merged this into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1735: STORM-203 Adding paths to default java library path

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1735 @knusbaum are you OK with the change? I am +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1760: Add topology stream-awareness to storm-redis

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1760#discussion_r86378199 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/bolt/RedisFilterBolt.java --- @@ -45,18 +48,41 @@ */ public class

[GitHub] storm issue #1735: STORM-203 Adding paths to default java library path

Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1735 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1696: STORM-2104: More graceful handling of acked/failed tuples...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1696 @hmcl @revans2 @knusbaum Could you guys take a look at this at some point? I noticed that two new PRs (https://github.com/apache/storm/pull/1752, https://github.com/apache/storm/pull/1753) were opened

[GitHub] storm pull request #1761: STORM-2184: Don't wakeup KafkaConsumer on shutdown...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/1761 STORM-2184: Don't wakeup KafkaConsumer on shutdown, spout methods are… ... not called by multiple threads at a time See https://issues.apache.org/jira/browse/STORM-2184 You can merge

[GitHub] storm issue #1752: STORM-2180: KafkaSpout ack() should handle re-balance

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1752 Looking at the code #1696 is a much more complete solutions. @knusbaum could you take a look at it and let us know what you think. --- If your project is set up for it, you can reply to this email

[GitHub] storm issue #1721: Update storm kafka docs.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1721 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1721: Update storm kafka docs.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1721 @aandis thanks for the fix. I merged it into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1721: Update storm kafka docs.

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1761: STORM-2184: Don't wakeup KafkaConsumer on shutdown, spout...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1761 +1 The discussion on STORM-2184 makes since that wakeup seems to not be needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm issue #1752: STORM-2180: KafkaSpout ack() should handle re-balance

Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1752 Fine by me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] storm pull request #1752: STORM-2180: KafkaSpout ack() should handle re-bala...

Github user knusbaum closed the pull request at: https://github.com/apache/storm/pull/1752 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1753: STORM-2180: KafkaSpout ack() should handle re-balance - 1...

Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1753 Closing for #1696 per request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1753: STORM-2180: KafkaSpout ack() should handle re-bala...

Github user knusbaum closed the pull request at: https://github.com/apache/storm/pull/1753 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1679: STORM-2087: storm-kafka-client - tuples not always being ...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1679 @revans2 apologies for the delay... started it and then something came in the way... will finish by tomorrow for sure. Will do my best to get this merged in asap... --- If your project is set up for

Re: How does the control flow in a Trident Topology work?

Hi Li, Here is an old Chinese article on Trident that explains the procedure with some images. I think you read Chinese, right ? The article is actually one in a series which may help you more to understand Trident. Cheers, Manu Zhang On Thu, Nov

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii can you up-merge and push your local repo changes so that we can merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as