[GitHub] storm issue #140: STORM-351 multilang python process fall into endless loop

[Chisha14]

Github user Chisha14 commented on the issue:

https://github.com/apache/storm/pull/140
  
@dashengju can you please provide a detailed example of how to run a python 
script with storm?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1918: STORM-2339: Beauty contest in storm.py

[tibkiss]

Github user tibkiss commented on the issue:

https://github.com/apache/storm/pull/1918
  
This PR has been pending since a while now.
Could someone please take a look?

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1914: STORM-2334 - Join Bolt implementation with unit tests

[roshannaik]

Github user roshannaik commented on the issue:

https://github.com/apache/storm/pull/1914
  
@arunmahadevan can you please commit this ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1962: storm jdbc topology should log the jdbc connection...

[tkuwabara789]

GitHub user tkuwabara789 opened a pull request:

https://github.com/apache/storm/pull/1962

storm jdbc topology should log the jdbc connection string to debug fa…

…ilures

Minor addition to expose JDBC connection string through logging in Hikari 
CP implementation.  For debugability purposes only.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tkuwabara789/storm apache-50022

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1962


commit b0c57ff437683e3f292f613200b9ee137ad1cebd
Author: Hiro Kuwabara 
Date:   2017-02-24T00:55:47Z

storm jdbc topology should log the jdbc connection string to debug failures




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Remove CHANGELOG file

[Roshan Naik]

Sounds like a good idea to me.
-roshan

On 2/23/17, 4:41 PM, "Jungtaek Lim"  wrote:

Hi devs,

I guess we discussed about this before, but didn't move to actual work.

I'd like to propose again removing CHANGELOG file in repository, and use
JIRA issue's fixed version(s).

Maintaining CHANGELOG to file is really easy to break. I've seen several
times and most of them is about backport. CHANGELOG file between branches
are inconsistent.

Suppose we would like to backport the issue to 1.0.x which is only applied
to 2.0.0, then we should fix CHANGELOG from three branches. Easy to miss
and redundant.

I'd also like to remove Project leads / Committers / Contributors in README
(at least Contributors) since it's also easy to break.

For PMC members we're maintaining it to website and I think that's enough.
For contributors I love what other projects are doing: extract unique
contributors name from commits or JIRA issues of release version and
mention them from release announce note.

What do you think?

Thanks,
Jungtaek Lim (HeartSaVioR)

[DISCUSS] Remove CHANGELOG file

[Jungtaek Lim]

Hi devs,

I guess we discussed about this before, but didn't move to actual work.

I'd like to propose again removing CHANGELOG file in repository, and use
JIRA issue's fixed version(s).

Maintaining CHANGELOG to file is really easy to break. I've seen several
times and most of them is about backport. CHANGELOG file between branches
are inconsistent.

Suppose we would like to backport the issue to 1.0.x which is only applied
to 2.0.0, then we should fix CHANGELOG from three branches. Easy to miss
and redundant.

I'd also like to remove Project leads / Committers / Contributors in README
(at least Contributors) since it's also easy to break.

For PMC members we're maintaining it to website and I think that's enough.
For contributors I love what other projects are doing: extract unique
contributors name from commits or JIRA issues of release version and
mention them from release announce note.

What do you think?

Thanks,
Jungtaek Lim (HeartSaVioR)

[GitHub] storm issue #1944: [STORM-2365] Support for specifying output stream in even...

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1944
  
(I saw 1.x-branch has CHANGELOG containing STORM-2365 in 1.1.0... It should 
be hard to follow, and I feel maintaining CHANGELOG for branches are useless.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1944: [STORM-2365] Support for specifying output stream in even...

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1944
  
@satishd Please mark JIRA issue resolved with proper fix versions. The 
CHANGELOG is easy to be broken (this issue is marked as 2.0.0 from CHANGELOG) 
so we shouldn't rely on that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1944: [STORM-2365] Support for specifying output stream in even...

[satishd]

Github user satishd commented on the issue:

https://github.com/apache/storm/pull/1944
  
@harshach This change was cherrypicked and merged earlier into 1.x-branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1944: [STORM-2365] Support for specifying output stream in even...

[harshach]

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1944
  
@HeartSaVioR did this get into 1.x-branch as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1951: STORM-2371 Implementing new eventhub driver

[SreeramGarlapati]

Github user SreeramGarlapati commented on the issue:

https://github.com/apache/storm/pull/1951
  
:clock1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

[SreeramGarlapati]

Github user SreeramGarlapati commented on a diff in the pull request:

https://github.com/apache/storm/pull/1951#discussion_r102774770
  
--- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java
 ---
@@ -92,50 +110,34 @@ public boolean isOpen() {
   }
 
   @Override
-  public EventData receive(long timeoutInMilliseconds) {
+  public EventData receive() {
 long start = System.currentTimeMillis();
-Message message = receiver.receive(timeoutInMilliseconds);
+Iterable receivedEvents=null;
+/*Get one message at a time for backward compatibility behaviour*/
+try {
+  receivedEvents = receiver.receive(1).get();
+}catch (Exception e){
+  logger.error("Exception occured during receive"+e.toString());
+}
 long end = System.currentTimeMillis();
 long millis = (end - start);
 receiveApiLatencyMean.update(millis);
 receiveApiCallCount.incr();
-
-if (message == null) {
-  //Temporary workaround for AMQP/EH bug of failing to receive messages
-  /*if(timeoutInMilliseconds > 100 && millis < 
timeoutInMilliseconds/2) {
-throw new RuntimeException(
-"Restart EventHubSpout due to failure of receiving messages in 
"
-+ millis + " millisecond");
-  }*/
+if (receivedEvents == null) {
   return null;
 }
-
 receiveMessageCount.incr();
-
-MessageId messageId = createMessageId(message);
-return EventData.create(message, messageId);
-  }
-  
-  private MessageId createMessageId(Message message) {
-String offset = null;
-long sequenceNumber = 0;
-
-for (Section section : message.getPayload()) {
-  if (section instanceof MessageAnnotations) {
-MessageAnnotations annotations = (MessageAnnotations) section;
-HashMap annonationMap = (HashMap) annotations.getValue();
-
-if (annonationMap.containsKey(OffsetKey)) {
-  offset = (String) annonationMap.get(OffsetKey);
-}
-
-if (annonationMap.containsKey(SequenceNumberKey)) {
-  sequenceNumber = (Long) annonationMap.get(SequenceNumberKey);
-}
-  }
+MessageId messageId=null;
+Message message=null;
+for (com.microsoft.azure.eventhubs.EventData receivedEvent : 
receivedEvents) {
+  messageId = new MessageId(partitionId,
+  receivedEvent.getSystemProperties().getOffset(),
+  receivedEvent.getSystemProperties().getSequenceNumber());
+  List body = new ArrayList();
+  body.add(new Data(new Binary((new String(receivedEvent.getBody(), 
Charset.defaultCharset())).getBytes(;
+  message = new Message(body);
--- End diff --

This is not equivalent to the existing behavior. Message could have other 
amqp sections - ApplicationProperties and SystemProperties.
Ideally, you should return com.microsoft.azure.eventhubs.EventData. Please 
remove the EventData type created in the spout library - to eliminate confusion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

[SreeramGarlapati]

Github user SreeramGarlapati commented on a diff in the pull request:

https://github.com/apache/storm/pull/1951#discussion_r102773626
  
--- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java
 ---
@@ -92,50 +110,34 @@ public boolean isOpen() {
   }
 
   @Override
-  public EventData receive(long timeoutInMilliseconds) {
+  public EventData receive() {
 long start = System.currentTimeMillis();
-Message message = receiver.receive(timeoutInMilliseconds);
+Iterable receivedEvents=null;
+/*Get one message at a time for backward compatibility behaviour*/
+try {
+  receivedEvents = receiver.receive(1).get();
+}catch (Exception e){
+  logger.error("Exception occured during receive"+e.toString());
+}
 long end = System.currentTimeMillis();
 long millis = (end - start);
 receiveApiLatencyMean.update(millis);
 receiveApiCallCount.incr();
-
-if (message == null) {
-  //Temporary workaround for AMQP/EH bug of failing to receive messages
-  /*if(timeoutInMilliseconds > 100 && millis < 
timeoutInMilliseconds/2) {
-throw new RuntimeException(
-"Restart EventHubSpout due to failure of receiving messages in 
"
-+ millis + " millisecond");
-  }*/
+if (receivedEvents == null) {
   return null;
 }
-
 receiveMessageCount.incr();
-
-MessageId messageId = createMessageId(message);
-return EventData.create(message, messageId);
-  }
-  
-  private MessageId createMessageId(Message message) {
-String offset = null;
-long sequenceNumber = 0;
-
-for (Section section : message.getPayload()) {
-  if (section instanceof MessageAnnotations) {
-MessageAnnotations annotations = (MessageAnnotations) section;
-HashMap annonationMap = (HashMap) annotations.getValue();
-
-if (annonationMap.containsKey(OffsetKey)) {
-  offset = (String) annonationMap.get(OffsetKey);
-}
-
-if (annonationMap.containsKey(SequenceNumberKey)) {
-  sequenceNumber = (Long) annonationMap.get(SequenceNumberKey);
-}
-  }
+MessageId messageId=null;
+Message message=null;
+for (com.microsoft.azure.eventhubs.EventData receivedEvent : 
receivedEvents) {
--- End diff --

>for (com.microsoft.azure.eventhubs.EventData receivedEvent : 
receivedEvents) { [](start = 4, length = 78)

Why ? In the receive(1) call above code - you explicitly specified receive 
1 message - so remove this..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1961: Storm 2290: Upgrading zookeeper to 3.4.9 for stabi...

[sachingsachin]

GitHub user sachingsachin opened a pull request:

https://github.com/apache/storm/pull/1961

Storm 2290: Upgrading zookeeper to 3.4.9 for stability



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sachingsachin/storm STORM-2290

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1961.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1961


commit 53574d44fe070523ac8e83e7df02e925d86efb06
Author: Sachin Goyal 
Date:   2016-04-01T00:37:40Z

Improve "_lostMessageCount" metric if a failed offset is beyond the 
configured "_spoutConfig.maxOffsetBehind"

Other small changes:
1) Rename offset to lowestValidOffset (Avoids confusion with 
generically-named variable "offset")
2) Move a warning to its proper place (no point warning if there are no 
omitted offsets)
3) Improve a second warning to convey the magnitude of lost offsets.

commit 1972bc4649418c8ccdc37304b1e794fe9d1c977a
Author: Sachin Goyal 
Date:   2017-02-23T17:24:02Z

STORM-2290: Upgrade zk version

commit 8f50a383f4c743683938e29511c02b70652d8349
Author: Sachin Goyal 
Date:   2017-02-23T17:31:49Z

REVERT back some local changes

commit 084211404356df5a9ecd6298701ec95880c16260
Author: Sachin Goyal 
Date:   2017-02-23T17:33:23Z

REVERT back some local changes

commit fb9f5c010a34b7229097be3a532482f0aa56fa4c
Author: Sachin Goyal 
Date:   2017-02-23T17:34:34Z

REVERT back some local changes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

[SreeramGarlapati]

Github user SreeramGarlapati commented on a diff in the pull request:

https://github.com/apache/storm/pull/1951#discussion_r102770531
  
--- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java
 ---
@@ -65,24 +69,38 @@ public EventHubReceiverImpl(EventHubSpoutConfig config, 
String partitionId) {
   }
 
   @Override
-  public void open(IEventHubFilter filter) throws EventHubException {
-logger.info("creating eventhub receiver: partitionId=" + partitionId + 
-   ", filterString=" + filter.getFilterString());
+  public void open(String offset) throws EventHubException {
+logger.info("creating eventhub receiver: partitionId=" + partitionId +
+", offset=" + offset);
 long start = System.currentTimeMillis();
-receiver = new ResilientEventHubReceiver(connectionString, entityName,
-   partitionId, consumerGroupName, defaultCredits, filter);
-receiver.initialize();
-
+try {
+  ehClient = 
EventHubClient.createFromConnectionString(connectionString).get();
+  receiver = ehClient.createEpochReceiver(
+  consumerGroupName,
+  partitionId,
+  offset,
+  false,
+  1).get();
+}catch (Exception e){
+  logger.info("Exception in creating EventhubClient"+e.toString());
+}
 long end = System.currentTimeMillis();
 logger.info("created eventhub receiver, time taken(ms): " + 
(end-start));
   }
 
   @Override
-  public void close() {
+  public void close(){
 if(receiver != null) {
-  receiver.close();
+  try {
+receiver.close().get();
--- End diff --

>.get() [](start = 24, length = 6)

if receiver.close() fails - this results into connection leak; handle this 
case. something like:
receiver.whenComplete(() -> { ehClient.closeSync() }).get();


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

[SreeramGarlapati]

Github user SreeramGarlapati commented on a diff in the pull request:

https://github.com/apache/storm/pull/1951#discussion_r102769617
  
--- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java
 ---
@@ -84,12 +82,39 @@ public void prepare(Map config, TopologyContext context,
@Override
public void execute(Tuple tuple) {
try {
-   
sender.send(boltConfig.getEventDataFormat().serialize(tuple));
+   EventData sendEvent = new 
EventData(boltConfig.getEventDataFormat().serialize(tuple));
+   if(boltConfig.getPartitionMode() && sender!=null)
+   sender.send(sendEvent).get();
+   else if(boltConfig.getPartitionMode() && sender==null)
+   throw new EventHubException("Sender is null");
+   else if(!boltConfig.getPartitionMode() && 
ehClient!=null)
+   ehClient.send(sendEvent).get();
+   else if(!boltConfig.getPartitionMode() && 
ehClient==null)
+   throw new EventHubException("ehclient is null");
collector.ack(tuple);
} catch (EventHubException ex) {
collector.reportError(ex);
collector.fail(tuple);
}
+   catch (Exception e){
+
+   }
--- End diff --

Why catch-all ?
This could potentially make this bolt a blackhole :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

[SreeramGarlapati]

Github user SreeramGarlapati commented on a diff in the pull request:

https://github.com/apache/storm/pull/1951#discussion_r102768443
  
--- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java
 ---
@@ -70,10 +69,9 @@ public void prepare(Map config, TopologyContext context,
logger.info("creating sender: " + 
boltConfig.getConnectionString()
+ ", " + boltConfig.getEntityPath() + ", " + 
myPartitionId);
try {
-   EventHubClient eventHubClient = EventHubClient.create(
-   boltConfig.getConnectionString(),
-   boltConfig.getEntityPath());
-   sender = 
eventHubClient.createPartitionSender(myPartitionId);
+   ehClient = 
EventHubClient.createFromConnectionString(boltConfig.getConnectionString()).get();
--- End diff --

>get [](start = 90, length = 3)

use methods ending with sync(...) - which could return cleaner exception 
stacks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

[SreeramGarlapati]

Github user SreeramGarlapati commented on a diff in the pull request:

https://github.com/apache/storm/pull/1951#discussion_r102767172
  
--- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java
 ---
@@ -22,10 +22,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import com.microsoft.eventhubs.client.EventHubClient;
+import com.microsoft.azure.eventhubs.*;
--- End diff --

>.*; [](start = 36, length = 3)

nit: keep them expanded - usual pattern in OS is to specifically import


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1954: STORM-2372: Pacemaker client doesn't clean up hear...

[knusbaum]

GitHub user knusbaum reopened a pull request:

https://github.com/apache/storm/pull/1954

STORM-2372: Pacemaker client doesn't clean up heartbeats properly. (2.x)

See #1952 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/knusbaum/incubator-storm master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1954


commit a64f135d2859d178e4645787e99638a84e1b192f
Author: Kyle Nusbaum 
Date:   2017-02-21T23:14:09Z

Fixing pacemaker delete_pulse

commit 6839fec10b94a56f6d9614547f4cabafcd9b355a
Author: Kyle Nusbaum 
Date:   2017-02-22T18:26:31Z

Fixing minor issue.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1954: STORM-2372: Pacemaker client doesn't clean up hear...

[knusbaum]

Github user knusbaum closed the pull request at:

https://github.com/apache/storm/pull/1954


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1934: STORM-2333: CGroup memory and CPU metrics

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1934
  
@jerrypeng Fixed the issue.  We were only checking if the SybSystem was 
enabled, but not if it was mounted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1934: STORM-2333: CGroup memory and CPU metrics

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1934
  
@jerrypeng Actually just found a bug working on a fix now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1934: STORM-2333: CGroup memory and CPU metrics

[jerrypeng]

Github user jerrypeng commented on the issue:

https://github.com/apache/storm/pull/1934
  
Thanks @revans2 +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1959: STORM-2374: Storm Kafka Client Test Topologies Must be Se...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1959
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1958: STORM-2374: Storm Kafka Client Test Topologies Must be Se...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1958
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1955: Add Streams API and Storm SQL docs to index page

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1955
  
Thanks for reviewing. I addressed all of review comments. I'll merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1955: Add Streams API and Storm SQL docs to index page

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1955


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1956: Add Storm SQL docs to index page for 1.x branch

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1956


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1956: Add Storm SQL docs to index page for 1.x branch

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1956
  
Since #1955 is superset of this, and it contains comments which can be also 
applied to this, I'll update this as well, and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1955: Add Streams API and Storm SQL docs to index page

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1955#discussion_r102670991
  
--- Diff: docs/index.md ---
@@ -31,6 +28,31 @@ Trident is an alternative interface to Storm. It 
provides exactly-once processin
 * [Trident spouts](Trident-spouts.html)   -- transactional and 
non-transactional data intake
 * [Trident RAS API](Trident-RAS-API.html) -- using the Resource Aware 
Scheduler with Trident.
 
+ Streams API
+
+Stream APIs is another alternative interface to Storm. It provides a typed 
API for expressing streaming computations and supports functional style 
operations.
+
+NOTE: Streams API is an `experimental` feature, and further works might 
break backward compatibility.
+We're also noticing it via annotating classes with marker interface 
`@InterfaceStability.Unstable`. 
+
+* [Streams API](Stream-API.html)
+
+ SQL
+
+The Storm SQL integration allows users to run SQL queries over streaming 
data in Storm.  
+
+NOTE: Storm SQL is an `experimental` feature, so the internal of Storm SQL 
and supported features are subject to change. 
+But small change will not affect the user experience. We will 
notice/announce the user when breaking UX change is introduced.
--- End diff --

Addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1955: Add Streams API and Storm SQL docs to index page

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1955#discussion_r102670961
  
--- Diff: docs/index.md ---
@@ -31,6 +28,31 @@ Trident is an alternative interface to Storm. It 
provides exactly-once processin
 * [Trident spouts](Trident-spouts.html)   -- transactional and 
non-transactional data intake
 * [Trident RAS API](Trident-RAS-API.html) -- using the Resource Aware 
Scheduler with Trident.
 
+ Streams API
+
+Stream APIs is another alternative interface to Storm. It provides a typed 
API for expressing streaming computations and supports functional style 
operations.
+
+NOTE: Streams API is an `experimental` feature, and further works might 
break backward compatibility.
+We're also noticing it via annotating classes with marker interface 
`@InterfaceStability.Unstable`. 
--- End diff --

Addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1955: Add Streams API and Storm SQL docs to index page

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1955#discussion_r102670975
  
--- Diff: docs/index.md ---
@@ -31,6 +28,31 @@ Trident is an alternative interface to Storm. It 
provides exactly-once processin
 * [Trident spouts](Trident-spouts.html)   -- transactional and 
non-transactional data intake
 * [Trident RAS API](Trident-RAS-API.html) -- using the Resource Aware 
Scheduler with Trident.
 
+ Streams API
+
+Stream APIs is another alternative interface to Storm. It provides a typed 
API for expressing streaming computations and supports functional style 
operations.
+
+NOTE: Streams API is an `experimental` feature, and further works might 
break backward compatibility.
+We're also noticing it via annotating classes with marker interface 
`@InterfaceStability.Unstable`. 
+
+* [Streams API](Stream-API.html)
+
+ SQL
+
+The Storm SQL integration allows users to run SQL queries over streaming 
data in Storm.  
+
+NOTE: Storm SQL is an `experimental` feature, so the internal of Storm SQL 
and supported features are subject to change. 
--- End diff --

Addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---