[GitHub] storm issue #2517: [STORM-2901] Reuse ZK connection for getKeySequenceNumber

2018-01-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2517 @danny0405 Could you squash commits into one? And it would be great you can provide a patch for 1.x-branch as well. Thanks in advance! ---

[GitHub] storm pull request #2513: [STORM-2897]Optimize defaults.yaml by removing the...

2018-01-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2513 ---

[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...

2018-01-21 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/2519 >@satishd @HeartSaVioR Unfortunately token.decodeIdentified() returns null value in Hive related Tokens. So previous code is broken for Hive. If we want this log, we need to add null check before

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2018-01-21 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2203 It seems like there is growing consensus that performance is good. Are there any objections to merging this? ---

[GitHub] storm issue #2517: [STORM-2901] Reuse ZK connection for getKeySequenceNumber

2018-01-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2517 @danny0405 OK. Please file an issue regarding the bug you found. ---

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2018-01-21 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2203 **ACKers=0, Workers=1** Const->Id->Null | 1.x | v2-metrics | v2-no-cm -- | -- | -- | -- elapsed (sec) | Throughput | Throughput | Throughput 60 | 553,881 | 557,223 |

[GitHub] storm pull request #2520: STORM-2903: Fix possible NullPointerException in A...

2018-01-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2520 ---

[GitHub] storm pull request #2519: STORM-2903: Fix possible NullPointerException in A...

2018-01-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2519 ---

Storm 1.0.6

2018-01-21 Thread Srikanth Viswanathan
Hi folks, I'm curious if there has been any discussion on cutting a Storm 1.0.6 release. We are particularly interested in seeing https://issues.apache.org/jira/browse/STORM-2690 get released, as it contains an important fix for those who want to run Storm 1.0.x on Mesos. Thanks.

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2018-01-21 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2203 **With Acking, Workers=1** TVL (rate=500k)| lat | throughput -- | -- | -- 1.x | 88.5ms | 52,913 v2-metrics | 91ms | 58,623 Const->Id->Null  | Throughput | avg

[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...

2018-01-21 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/2519 @arunmahadevan @omkreddy I have looked into that code before putting my initial comment. Not all `TokenIdentifier` implementations have implemented `toString()` with user information.

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2018-01-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 @ptgoetz Could we have document for this? It's OK you would want to document it after merging this, but follow-up issue should be blocker for the release. ---

[GitHub] storm issue #2504: STORM-2887: store metrics into RocksDB

2018-01-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2504 @agresch Never mind. I can see document file. For me, removing first blank line works. Could you try out and see it works, and if it works, could you squash commits into one and let me

[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...

2018-01-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2519 @omkreddy @arunmahadevan @satishd My bad I forgot what I was doing. Yes that was why I got user information from `token.decodeIdentified().getUser()`. Do we want to revert the

[GitHub] storm issue #2475: STORM-2862: More flexible logging in multilang

2018-01-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2475 @hmcc Could you squash commits into one? #2474 as well. Thanks in advance! ---

[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...

2018-01-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2487 @kishorvpatil Any updates? ---

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2018-01-21 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2203 @HeartSaVioR Absolutlely! I just want to make sure we are all on board with the changes. ---

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2018-01-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 @ptgoetz OK great. I filed an issue for documentation: https://issues.apache.org/jira/browse/STORM-2904 Please handle this issue. I think we can merge this now. ---

[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...

2018-01-21 Thread omkreddy
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/2519 @satishd @HeartSaVioR Unfortunately token.decodeIdentified() return null value in Hive related Tokens. So if we want this log, we need to add null check before printing