Re: [DISCUSS] [Storm-Kafka] - Maintenance, Branch Support, and Deprecation Plans for storm-kafka and storm-kaka-client

2018-02-12 Thread Jungtaek Lim
I forgot the one, but this is great time to revisit this, since we got resolved many storm-kafka-client issues hence feeling it as fairly stable. I'm +1 on deprecate storm-kafka at 1.x version lines and remove it at 2.0.0. Do we want to have explicit VOTE to receive more opinions here? Thanks,

[DISCUSS] consider EOL for version lines

2018-02-12 Thread Jungtaek Lim
Hi devs, I've noticed that we are providing 4 different version lines (1.1.x, 1.0.x, 0.10.x, 0.9.x) in download page, and I expect we will add one more for 1.2.0. Moreover, we have one more develop version line (2.0.0 - master) which most of development happens there. Recently we're releasing 3

[GitHub] storm issue #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2554 That is correct. With the current default RocksDB implementation, we would have workers forward to the Supervisor, and the Supervisor metric processor would be NimbusMetricProcessor - sending them

[GitHub] storm issue #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2554 @agresch > We're planning on getting the metrics forwarded from the workers to the Supervisor and inserting from HBase there (or forwarding to Nimbus for RocksDB). In the non-HBase

[GitHub] storm-site pull request #2: Update dependencies

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm-site/pull/2 ---

Re: [VOTE] Release Apache Storm 1.0.6 (rc3)

2018-02-12 Thread P. Taylor Goetz
This vote is now closed and passes with 3 binding +1 votes, and no 0 or -1 votes. Vote tally: +1: - Bobby Evans - Jungtaek Lim - P. Taylor Goetz I will release the staged artifacts and announce the release after 24 hours. -Taylor > On Feb 8, 2018, at 2:22 PM, P. Taylor Goetz

[RESULT] [VOTE] Release Apache Storm 1.1.2 (rc3)

2018-02-12 Thread P. Taylor Goetz
This vote is now closed and passes with 3 binding +1 votes and no -1 or 0 votes. Vote tally: +1: - Bobby Evans - Jungtaek Lim - P. Taylor Goetz I will release the staged artifacts and announce the release after 24 hours. -Taylor > On Feb 8, 2018, at 12:48 PM, P. Taylor Goetz

Re: [VOTE] Release Apache Storm 1.1.2 (rc3)

2018-02-12 Thread P. Taylor Goetz
+1 (binding) -Taylor > On Feb 8, 2018, at 12:48 PM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.1.2 (rc3) > > Full list of changes in this release: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.1.2-rc3/RELEASE_NOTES.html

Re: [VOTE] Release Apache Storm 1.0.6 (rc3)

2018-02-12 Thread P. Taylor Goetz
+1 (binding) -Taylor > On Feb 8, 2018, at 2:22 PM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.0.6 (rc3) > > Full list of changes in this release: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.6-rc3/RELEASE_NOTES.html >

[RESULT] [VOTE] Release Apache Storm 1.2.0 (rc4)

2018-02-12 Thread P. Taylor Goetz
This vote is now closed and passes with 4 binding +1 votes, 1 non-binding +1, and no 0 or -1 votes. Vote tally (* indicates a binding vote): +1: - Jungtaek Lim* - Satish Duggana* - Arun Iyer* - Alexandre Vermeerbergen - Bobby Evans* I will release the staged artifacts and announce the release

[GitHub] storm-site issue #2: Update dependencies

2018-02-12 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm-site/pull/2 +1 ---

[GitHub] storm pull request #2487: [STORM-2873] Do not delete backpressure ephemeral ...

2018-02-12 Thread kishorvpatil
Github user kishorvpatil closed the pull request at: https://github.com/apache/storm/pull/2487 ---

[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...

2018-02-12 Thread kishorvpatil
Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2487 closing the PR as no longer needed for master branch. ---

Re: [VOTE] Release Apache Storm 1.2.0 (rc4)

2018-02-12 Thread Bobby Evans
+1 I built from source all of the unit tests passed and some basic integration tests passed too. On Sat, Feb 10, 2018 at 12:00 PM Alexandre Vermeerbergen < avermeerber...@gmail.com> wrote: > Hello, > > +1 (non binding) > > Details: I almost got nuts when applying storm-kafka-client-1.2.0 RC4 >

Re: [VOTE] Release Apache Storm 1.0.6 (rc3)

2018-02-12 Thread Bobby Evans
Happy to do the check. This is something we don't want to get wrong. On Fri, Feb 9, 2018 at 5:38 PM P. Taylor Goetz wrote: > Doh! I didn’t even think consider that it was likely autogenerated by an > IDE and likely identical to what the JDK would generate. > > I agree with

[GitHub] storm pull request #2502: new PR for STORM-2306 : Messaging subsystem redesi...

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2502#discussion_r167625247 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -40,109 +40,117 @@ import org.apache.storm.nimbus.NimbusInfo;

[GitHub] storm issue #2555: STORM-2841 Use extended class instead of partial mock for...

2018-02-12 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2555 +1 ---

[GitHub] storm pull request #2553: STORM-2935 update autocredential metric documentat...

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2553 ---

[GitHub] storm issue #2553: STORM-2935 update autocredential metric documentation

2018-02-12 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2553 Thanks @agresch I just merged this into master. ---

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2554#discussion_r167608762 --- Diff: storm-server/src/main/java/org/apache/storm/metricstore/WorkerMetricsProcessor.java --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2554#discussion_r167608546 --- Diff: storm-server/src/main/java/org/apache/storm/metricstore/WorkerMetricsProcessor.java --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2554#discussion_r167607557 --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java --- @@ -1040,6 +1039,13 @@ // and log an error message, so just validating

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2554#discussion_r167608078 --- Diff: storm-server/src/main/java/org/apache/storm/metricstore/MetricStoreConfig.java --- @@ -41,5 +41,23 @@ public static MetricStore configure(Map

[GitHub] storm issue #2553: STORM-2935 update autocredential metric documentation

2018-02-12 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2553 Can this be merged? ---

[GitHub] storm pull request #2555: STORM-2841 Use extended class instead of partial m...

2018-02-12 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2555 STORM-2841 Use extended class instead of partial mock for TestHiveBolt * while mocking partially, oddly it calls real method intermittently which breaks test Please refer