[GitHub] storm issue #2621: [STORM-3017] Refactor pacemaker client exception handling

2018-04-18 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2621 @revans2 @srdo Could you please take a look if you get a chance? Thanks ---

[GitHub] storm issue #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_WORKERS ...

2018-04-18 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2634 @revans2 @roshannaik Could you please take a look if you get a chance as we discussed about this in https://issues.apache.org/jira/browse/STORM-3021 ---

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-18 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182545551 --- Diff: docs/Resource_Aware_Scheduler_overview.md --- @@ -184,6 +184,10 @@ The user can set some default configurations for the Resource Aware

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-18 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182552073 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-18 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182549691 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3032,9 +3019,19 @@ public void submitTopologyWithOpts(String

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-18 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182628537 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-18 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r182584203 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3032,9 +3019,19 @@ public void submitTopologyWithOpts(String

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-18 Thread srishtyagrawal
GitHub user srishtyagrawal opened a pull request: https://github.com/apache/storm/pull/2637 Map of Spout configurations from `storm-kafka` to `storm-kafka-client` As per @srdo and @ptgoetz's replies on the Storm Dev mailing list, I am adding the spout configuration map in the