[GitHub] storm issue #1807: fix NullPointException with acked.get(rtp)

2016-12-05 Thread cutd
Github user cutd commented on the issue: https://github.com/apache/storm/pull/1807 @srdo I think you are right! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1815: STORM-2235 Introduce new option: 'add remote repos...

2016-12-05 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1815 STORM-2235 Introduce new option: 'add remote repositories' for dependency resolver * add '--artifactRepositories' option to pull the artifacts from other than Maven Central In this

Re: Are storm metrics reported through JMX too?

2016-12-05 Thread Alessandro Bellina
Hi Taylor Please see latest commit in: https://github.com/abellina/storm/tree/reporters Specifically inside: storm-core/src/jvm/org/apache/storm/metrics2 I have a default config that sets up a couple of reporters in default.yaml. The format is inline with what we discussed, but updated with what

[GitHub] storm issue #1807: fix NullPointException with acked.get(rtp)

2016-12-05 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1807 @hmcl Yes, the case I'm thinking about is where the topology has acking enabled, but the spout is set to auto-commit mode. It would probably be fine to do best-effort retrying when using that setup,

Re: Are storm metrics reported through JMX too?

2016-12-05 Thread Alessandro Bellina
Yes. Will PR this tonight Taylor. Thanks! On Monday, December 5, 2016, 12:37:18 PM CST, P. Taylor Goetz wrote:Alessandro, Are you in a position to open a pull request against the metrics_v2 branch? I’d like to start integrating the work I’ve been doing with the reporter

[GitHub] storm pull request #1814: STORM-1308

2016-12-05 Thread kamleshbhatt
GitHub user kamleshbhatt opened a pull request: https://github.com/apache/storm/pull/1814 STORM-1308 Please Review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kamleshbhatt/storm master Alternatively you can review and apply

Re: Are storm metrics reported through JMX too?

2016-12-05 Thread P. Taylor Goetz
Alessandro, Are you in a position to open a pull request against the metrics_v2 branch? I’d like to start integrating the work I’ve been doing with the reporter configuration stuff you have. If what you have is incomplete/WIP, that’s not a big deal as the metrics_v2 branch is a feature branch

[GitHub] storm issue #1807: fix NullPointException with acked.get(rtp)

2016-12-05 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1807 Two things. @cutd I am +1 for your patch. @srdo I see your point. If I understand correctly what you mean is that either the Spout guarantees at least once or it doesn't. If it

[GitHub] storm issue #1785: [STORM-2201] Add dynamic scheduler configuration loading.

2016-12-05 Thread ppoulosk
Github user ppoulosk commented on the issue: https://github.com/apache/storm/pull/1785 @revans2, Thanks for the review. I've merged in a commit to fix the issues you have pointed out. --- If your project is set up for it, you can reply to this email and have your reply appear on