[GitHub] storm pull request #1890: [STORM-2311]A browser which is outside the cluster...

GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/1890 [STORM-2311]A browser which is outside the cluster cant's access stor… JIRA Issue: [https://issues.apache.org/jira/browse/STORM-2311](url) when storm cluster is in a security mode

[GitHub] storm pull request #1866: STORM-2279: Unable to open bolt page of storm ui

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1866#discussion_r97013917 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,7 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String

[GitHub] storm pull request #1889: STORM-2305: STORM-2279 calculates task index diffe...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1889#discussion_r97013631 --- Diff: storm-core/src/jvm/org/apache/storm/utils/TupleUtils.java --- @@ -40,7 +40,11 @@ public static boolean isTick(Tuple tuple) {

[GitHub] storm pull request #1889: STORM-2305: STORM-2279 calculates task index diffe...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1889#discussion_r97013363 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,8 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String

Re: [DISCUSS] Adopt pull request template

I am ok with adopting templates but lets keep this process simpler. We've new contributors coming in and they probably didn't have chance to go through process. We can guide them through the process or have strict template that everyone needs to adopt to. I don't think having

[DISCUSS] Release Storm 1.0.3

Hi devs, While we're working on issues targeted for 1.1.0, remaining issues on 1.1.0 epic are not relevant to 1.0.3. Since we also have lots of resolved issues for 1.0.3 [1 ], I think it would be better to start release process for

[GitHub] storm pull request #1884: Storm-2236 Kafka Spout with manual partition manag...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1884 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1882: STORM-1292: port backtype.storm.messaging-test to java Vi...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1882 @kamleshbhatt I can't rebase either so cherry-picked some valid commits and rebased myself. Thanks for the work. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request #1882: STORM-1292: port backtype.storm.messaging-test to ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1882 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1889: STORM-2305: STORM-2279 calculates task index different fr...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1889 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1866: STORM-2279: Unable to open bolt page of storm ui

Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1866 👍 for reverting from 1.x & 1.0.x branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1866: STORM-2279: Unable to open bolt page of storm ui

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1866 @arunmahadevan @raghavgautam To summary, this issue was not valid for 1.x and 1.0.x branch, since field grouper and also nimbus take care of negative hashCode via using `mod`. My bad. I'll

[GitHub] storm pull request #1889: STORM-2305: STORM-2279 calculates task index diffe...

GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1889 STORM-2305: STORM-2279 calculates task index different from grouper code @HeartSaVioR @arunmahadevan Please review. You can merge this pull request into a Git repository by running: $ git

[GitHub] storm pull request #1866: STORM-2279: Unable to open bolt page of storm ui

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1866#discussion_r97005261 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,7 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String

[GitHub] storm issue #1884: Storm-2236 Kafka Spout with manual partition management f...

Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1884 @HeartSaVioR Commits squashed, please help to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request #1864: STORM-2176 Workers do not shutdown cleanly and wor...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1864 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96995077 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/KafkaTopicSelector.java --- @@ -0,0 +1,26 @@ +/** + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96951710 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to

[GitHub] storm issue #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1808 The travis test failures are unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96926665 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to

[GitHub] storm issue #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1808 @hmcl I think I addressed all of your review comments. I also re-based to deal with the merge conflict. If everything looks good I will squash some of the commits. There are a lot. --- If your

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96925318 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/mapper/FieldNameBasedTupleToKafkaMapper.java --- @@ -0,0 +1,41 @@

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96925159 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/KafkaTopicSelector.java --- @@ -0,0 +1,26 @@ +/** + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96925279 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/mapper/FieldNameBasedTupleToKafkaMapper.java --- @@ -0,0 +1,41 @@

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96924990 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to

Re: [DISCUSS] Adopt pull request template

I am strongly +1. In addition to the templates suggested by Jungtaek, in the past I suggested the template bellow to a different project. It is a bit simpler than the ones listed, as I think it may be too demanding to ask people to categorize in the git message the type of contribution the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96923940 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96923481 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutManager.java --- @@ -44,29 +43,30 @@ //

[GitHub] storm issue #1882: STORM-1292: port backtype.storm.messaging-test to java Vi...

Github user kamleshbhatt commented on the issue: https://github.com/apache/storm/pull/1882 @harshach I tried your suggestion "git rebase -i HEAD~9" and kept just one comment and put s in front of all other comments. It gives error Cannot 'squash' without a previous commit

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96911529 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/RoundRobinManualPartitioner.java --- @@ -15,14 +15,26 @@ * See the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96909498 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTuple.java --- @@ -15,22 +15,33 @@ * See the License for the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96908491 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedSubscription.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96908178 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java --- @@ -1,16 +1,35 @@ +/* + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96907232 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -325,15 +310,19 @@ private boolean

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96904191 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -61,129 +66,244 @@ * If no offset has

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96902715 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java --- @@ -1,16 +1,35 @@ +/* + * Licensed

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96903456 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/RoundRobinManualPartitioner.java --- @@ -15,14 +15,26 @@ * See the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96897291 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -325,15 +310,19 @@ private boolean

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96894587 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ByTopicRecordTranslator.java --- @@ -0,0 +1,93 @@ +/* + * Licensed

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96893867 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/ByTopicRecordTranslator.java --- @@ -0,0 +1,93 @@ +/* + * Licensed

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96891568 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/FieldIndexTopicSelector.java --- @@ -0,0 +1,52 @@ +/** + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96891946 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/selector/FieldNameTopicSelector.java --- @@ -0,0 +1,49 @@ +/** + *

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96889563 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -51,7 +51,9 @@ * This bolt uses 0.8.2 Kafka Producer API.

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96889298 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/Subscription.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96887342 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -61,129 +66,244 @@ * If no offset

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96886556 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -61,129 +66,244 @@ * If no offset

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96884451 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -225,11 +213,7 @@ public void nextTuple() {

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96879498 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96879307 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96879248 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96877333 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96877744 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96875424 --- Diff: docs/storm-kafka-client.md --- @@ -1,90 +1,232 @@ -#Storm Kafka Spout with New Kafka Consumer API +#Storm Apache Kafka integration using the

[GitHub] storm issue #1873: STORM-2296 Kafka spout - no duplicates on leader changes

Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1873 Created another pull request for 1.x-branch: https://github.com/apache/storm/pull/1888 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request #1888: STORM-2296 Kafka spout no dup on leader changes 1 ...

GitHub user ernisv opened a pull request: https://github.com/apache/storm/pull/1888 STORM-2296 Kafka spout no dup on leader changes 1 x Current behavior of Kafka spout emits duplicate tuples whenever Kafka topic leader's change. In case of exception caused by leader changes,