[GitHub] storm issue #140: STORM-351 multilang python process fall into endless loop

2017-02-23 Thread Chisha14
Github user Chisha14 commented on the issue: https://github.com/apache/storm/pull/140 @dashengju can you please provide a detailed example of how to run a python script with storm? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #1918: STORM-2339: Beauty contest in storm.py

2017-02-23 Thread tibkiss
Github user tibkiss commented on the issue: https://github.com/apache/storm/pull/1918 This PR has been pending since a while now. Could someone please take a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1914: STORM-2334 - Join Bolt implementation with unit tests

2017-02-23 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/1914 @arunmahadevan can you please commit this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #1962: storm jdbc topology should log the jdbc connection...

2017-02-23 Thread tkuwabara789
GitHub user tkuwabara789 opened a pull request: https://github.com/apache/storm/pull/1962 storm jdbc topology should log the jdbc connection string to debug fa… …ilures Minor addition to expose JDBC connection string through logging in Hikari CP implementation. For

Re: [DISCUSS] Remove CHANGELOG file

2017-02-23 Thread Roshan Naik
Sounds like a good idea to me. -roshan On 2/23/17, 4:41 PM, "Jungtaek Lim" wrote: Hi devs, I guess we discussed about this before, but didn't move to actual work. I'd like to propose again removing CHANGELOG file in repository, and use JIRA issue's

[DISCUSS] Remove CHANGELOG file

2017-02-23 Thread Jungtaek Lim
Hi devs, I guess we discussed about this before, but didn't move to actual work. I'd like to propose again removing CHANGELOG file in repository, and use JIRA issue's fixed version(s). Maintaining CHANGELOG to file is really easy to break. I've seen several times and most of them is about

[GitHub] storm issue #1944: [STORM-2365] Support for specifying output stream in even...

2017-02-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1944 (I saw 1.x-branch has CHANGELOG containing STORM-2365 in 1.1.0... It should be hard to follow, and I feel maintaining CHANGELOG for branches are useless.) --- If your project is set up for it,

[GitHub] storm issue #1944: [STORM-2365] Support for specifying output stream in even...

2017-02-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1944 @satishd Please mark JIRA issue resolved with proper fix versions. The CHANGELOG is easy to be broken (this issue is marked as 2.0.0 from CHANGELOG) so we shouldn't rely on that. --- If your

[GitHub] storm issue #1944: [STORM-2365] Support for specifying output stream in even...

2017-02-23 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1944 @harshach This change was cherrypicked and merged earlier into 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #1944: [STORM-2365] Support for specifying output stream in even...

2017-02-23 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1944 @HeartSaVioR did this get into 1.x-branch as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1951: STORM-2371 Implementing new eventhub driver

2017-02-23 Thread SreeramGarlapati
Github user SreeramGarlapati commented on the issue: https://github.com/apache/storm/pull/1951 :clock1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

2017-02-23 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/1951#discussion_r102774770 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -92,50 +110,34 @@ public

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

2017-02-23 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/1951#discussion_r102773626 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -92,50 +110,34 @@ public

[GitHub] storm pull request #1961: Storm 2290: Upgrading zookeeper to 3.4.9 for stabi...

2017-02-23 Thread sachingsachin
GitHub user sachingsachin opened a pull request: https://github.com/apache/storm/pull/1961 Storm 2290: Upgrading zookeeper to 3.4.9 for stability You can merge this pull request into a Git repository by running: $ git pull https://github.com/sachingsachin/storm STORM-2290

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

2017-02-23 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/1951#discussion_r102770531 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -65,24 +69,38 @@ public

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

2017-02-23 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/1951#discussion_r102769617 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -84,12 +82,39 @@ public void prepare(Map

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

2017-02-23 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/1951#discussion_r102768443 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -70,10 +69,9 @@ public void prepare(Map

[GitHub] storm pull request #1951: STORM-2371 Implementing new eventhub driver

2017-02-23 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/1951#discussion_r102767172 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -22,10 +22,8 @@ import

[GitHub] storm pull request #1954: STORM-2372: Pacemaker client doesn't clean up hear...

2017-02-23 Thread knusbaum
GitHub user knusbaum reopened a pull request: https://github.com/apache/storm/pull/1954 STORM-2372: Pacemaker client doesn't clean up heartbeats properly. (2.x) See #1952 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #1954: STORM-2372: Pacemaker client doesn't clean up hear...

2017-02-23 Thread knusbaum
Github user knusbaum closed the pull request at: https://github.com/apache/storm/pull/1954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1934: STORM-2333: CGroup memory and CPU metrics

2017-02-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1934 @jerrypeng Fixed the issue. We were only checking if the SybSystem was enabled, but not if it was mounted. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #1934: STORM-2333: CGroup memory and CPU metrics

2017-02-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1934 @jerrypeng Actually just found a bug working on a fix now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1934: STORM-2333: CGroup memory and CPU metrics

2017-02-23 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/1934 Thanks @revans2 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #1959: STORM-2374: Storm Kafka Client Test Topologies Must be Se...

2017-02-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1959 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1958: STORM-2374: Storm Kafka Client Test Topologies Must be Se...

2017-02-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1958 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1955: Add Streams API and Storm SQL docs to index page

2017-02-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1955 Thanks for reviewing. I addressed all of review comments. I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request #1955: Add Streams API and Storm SQL docs to index page

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1956: Add Storm SQL docs to index page for 1.x branch

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1956 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1956: Add Storm SQL docs to index page for 1.x branch

2017-02-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1956 Since #1955 is superset of this, and it contains comments which can be also applied to this, I'll update this as well, and merge. --- If your project is set up for it, you can reply to this

[GitHub] storm pull request #1955: Add Streams API and Storm SQL docs to index page

2017-02-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1955#discussion_r102670991 --- Diff: docs/index.md --- @@ -31,6 +28,31 @@ Trident is an alternative interface to Storm. It provides exactly-once processin * [Trident

[GitHub] storm pull request #1955: Add Streams API and Storm SQL docs to index page

2017-02-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1955#discussion_r102670961 --- Diff: docs/index.md --- @@ -31,6 +28,31 @@ Trident is an alternative interface to Storm. It provides exactly-once processin * [Trident

[GitHub] storm pull request #1955: Add Streams API and Storm SQL docs to index page

2017-02-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1955#discussion_r102670975 --- Diff: docs/index.md --- @@ -31,6 +28,31 @@ Trident is an alternative interface to Storm. It provides exactly-once processin * [Trident