[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...

2017-09-28 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2249
  
Merged via 
https://github.com/apache/storm/commit/48f6969027e7b02a5b9220577189d3911aa2226d

@srdo 
Sorry I forgot to add auto close message while squashing commits. Could you 
close this?
And please craft the patch for 1.x branch since it doesn't looks like a 
clean cherry-pick.
Thanks in advance!


---


[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...

2017-09-28 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2249
  
This PR has been waiting for about 2 months, and once it gets +1 and no -1, 
it can be merged.
I'm +1 and will just merge.

@hmcl Please vote -1 later and rollback the merge if you have concern about 
the patch and would want to vote -1.


---


[GitHub] storm pull request #2351: [STORM-2765] Disallow colons in blobstore key name

2017-09-28 Thread Ethanlm
GitHub user Ethanlm opened a pull request:

https://github.com/apache/storm/pull/2351

[STORM-2765] Disallow colons in blobstore key name

We should disallow colons in blobstore key name.  HDFS prohibits the use of 
":" in path name. 


![image](https://user-images.githubusercontent.com/14900612/30991627-6552b530-a46b-11e7-98dc-e261af791988.png)


[ Related code is 
here](https://github.com/apache/hadoop/blob/branch-2.6.1/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java#L237)

Secondly, the original code uses two different functions to validate key 
names in different places. We probably just want to use one to avoid confusion. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Ethanlm/storm STORM-2765

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2351


commit ff0f1e7d464f8992f5f2f21859b2a925a03fdd7b
Author: Ethan Li 
Date:   2017-09-28T18:46:14Z

[STORM-2765] Disallow colons in blobstore key name




---


[GitHub] storm pull request #2350: STORM-2764: Only login the user if not already don...

2017-09-28 Thread revans2
GitHub user revans2 opened a pull request:

https://github.com/apache/storm/pull/2350

STORM-2764:  Only login the user if not already done

If the changes look good I am happy to put up pull requests for other 
branches too.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revans2/incubator-storm STORM-2764

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2350


commit 87ad03585276f4c02b54da70a0fe62ebcdcabe8c
Author: Robert (Bobby) Evans 
Date:   2017-09-28T19:42:36Z

STORM-2764:  Only login the user if not already done




---


IMetricConsumer not working

2017-09-28 Thread Walid Aljoby

Hi Everyone,
I have some concerns with using a central bolt for collecting some statistics 
of interest from running topology.I tried to use IMetricConsumer, thus I 
employed storm-metrics-statsd from endgameinc/storm-metrics-statsd, for my 
topology, and configured it as: 
## Metrics Consumers
 topology.metrics.consumer.register:
  - class: "org.apache.storm.starter.perf.StatsdMetricConsumer"
    parallelism.hint: 1
    argument:
   metrics.statsd.host: "10.10.10.20"
   metrics.statsd.port: 8125
   metrics.statsd.prefix: "storm.metrics."

However, when I run the topology I could see metric information in UI and seen 
that  storm-metrics-statsd run at one of machine workers.The concerns are about 
not seeing the 8125 port is running, and therefore I could not see any file for 
metrics anywhere..Anybody please have some suggestion?

Many thanks
Walid













  
|  
|   
|   
|   ||

   |

  |
|  
||  
endgameinc/storm-metrics-statsd
 storm-metrics-statsd - Storm Metrics module for reporting to statsd  |   |

  |

  |

 

[GitHub] storm pull request #2349: [STORM-2718] Show some messages on Logviewer index...

2017-09-28 Thread Ethanlm
GitHub user Ethanlm opened a pull request:

https://github.com/apache/storm/pull/2349

[STORM-2718] Show some messages on Logviewer index page

JIRA: https://issues.apache.org/jira/browse/STORM-2718

Display some messages on logviewer front page so that the first-time users 
can be less confused. 


![image](https://user-images.githubusercontent.com/14900612/30970144-fe81622a-a429-11e7-8a41-821daca8f83e.png)




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Ethanlm/storm STORM-2718

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2349






---


[GitHub] storm pull request #2340: [STORM-2753] Avoid shutting down netty server on n...

2017-09-28 Thread Ethanlm
Github user Ethanlm closed the pull request at:

https://github.com/apache/storm/pull/2340


---


[GitHub] storm pull request #2346: Quick fix: typo in LogviewerServer

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2346


---


[GitHub] storm pull request #2339: STORM-2084: Refactor localization to combine files...

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2339


---


[GitHub] storm pull request #2344: [STORM-2758] fix: logviewer_search page not found

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2344


---


[GitHub] storm pull request #2348: [STORM-2757] Fix broken log links when HTTPS is in...

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2348


---