[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...

2017-11-24 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 Hi,@revans2,I'm not sure whether the ci's failure related to me.And I have add a retry to DRPCInvaction,could you help me to review it? ---

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153037892 --- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java --- @@ -1589,18 +1570,16 @@ public static ComponentPageInfo aggCompExecsStats(

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153036973 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -43,13 +44,15 @@ private static Logger LOG =

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153037176 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -147,21 +153,52 @@ protected void

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153036746 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -1293,6 +1318,44 @@ @isPositiveNumber public static final String

[GitHub] storm pull request #2428: STORM-2826: Set key/value deserializer fields when...

2017-11-24 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2428#discussion_r153035388 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -320,20 +320,17 @@ private

[GitHub] storm pull request #2428: STORM-2826: Set key/value deserializer fields when...

2017-11-24 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2428#discussion_r153035015 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -320,20 +320,17 @@ private Builder(Builder

[GitHub] storm pull request #2429: STORM-2813: Use a class for normalized resources n...

2017-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2429 ---

[GitHub] storm pull request #2428: STORM-2826: Set key/value deserializer fields when...

2017-11-24 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2428#discussion_r153033776 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -320,20 +320,17 @@ private

[GitHub] storm issue #2432: [STORM-2829] fix logviewer deepSearch direct self-referen...

2017-11-24 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2432 Thanks @Ethanlm, merged to master ---

[GitHub] storm pull request #2432: [STORM-2829] fix logviewer deepSearch direct self-...

2017-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2432 ---

[GitHub] storm pull request #2434: STORM-2830: Upgrade to Jackson 2.9.2. Switch to us...

2017-11-24 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2434 STORM-2830: Upgrade to Jackson 2.9.2. Switch to using the Jackson BOM… … to keep components in sync The breaking change lists are here