Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2493
@revans2 I just added @danny0405 to contributor list and assigned to the
JIRA issue.
@danny0405 Could you please provide a 1.x patch as well? Thanks in advance!
---
Github user OuYangLiang closed the pull request at:
https://github.com/apache/storm/pull/2494
---
Github user OuYangLiang commented on the issue:
https://github.com/apache/storm/pull/2494
@srdo thanks for the explanation, close this PR.
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2493
@revans2 This is the JIRA issue:
https://issues.apache.org/jira/browse/STORM-2879
---
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2502
@revans2 , UTs for the storm-client module were fixed (including
JCQueueTest). They run cleanly for me. Are you seeing them fail in your local
setup ?
**Rebasing:** Due to the length
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2241
This PR page has become unusable. Most of the time it doesn't load. If it
does load, it is too slow to use...even for just typing a comment. Let stop
using this and switch to the [new
Github user roshannaik closed the pull request at:
https://github.com/apache/storm/pull/2241
---
GitHub user roshannaik opened a pull request:
https://github.com/apache/storm/pull/2502
new PR for STORM-2306
Since the [old PR page](https://github.com/apache/storm/pull/2241) had
become unusable (due to lots of old comments). Creating a new PR for the same.
You can merge this
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2499
Yes let's merge this first.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2498
No I meant we are publishing a new artifact which has relocated
dependencies.
You can refer below to see how Flink addressed this.
https://github.com/apache/flink-shaded
---
Github user dujiashu commented on the issue:
https://github.com/apache/storm/pull/2492
@srdo Thanks for you help.
https://issues.apache.org/jira/browse/STORM-2883
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2499
@HeartSaVioR , are we ok to merge this in 1.x while we wait for the right
fix for #2498 ?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2498
I think "option 2" is good for Storm 2.0 and it may be ok have the users
rebuild their topologies that relies on storm-druid and use the relocated
package names. With "option 4", users have to
GitHub user dvehar opened a pull request:
https://github.com/apache/storm/pull/2501
Add anchor links to the README
Makes it easier to jump to the HDFS Spout documentation. The HDFS Bolt link
isn't really needed but is done for consistency's sake.
You can merge this pull request
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2498
4. publish "a" shaded artifact which shades and relocates error-prone
artifacts
I proposed 4 in discussion thread, and now Flink is leveraging 4. I was
worrying about LICENSE issue
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2498
@arunmahadevan
I think we are all on the same page here. All I am saying is that this
patch by itself does not fix STORM-2881 for 2.x and as such I don't want it to
go in as is, we need to
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2241
Sorry it has taken me so long to get back to this. I did a quick pass
through the code, but I need to spend some time to go more in depth. I expect
to be doing this this afternoon and tomorrow.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159742244
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159742835
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159736224
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159734646
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -184,30 +191,25 @@ public void
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159735761
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159735958
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2498
@revans2 , the latest version of tranquility-core available is 0.8.2 which
has this curator 2.6.0 transitive dependency.
I think the storm-druid unit tests would use the 2.6.0 version
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2493
@danny0405 I merged this into master, but the patch does not apply cleanly
to 1.x (Slot.java moved locations)
Could you please provide a 1.x patch as well? Also do you have a JIRA ID
that
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2493
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2498
This patch is problematic without shading. With this the unit tests will
run with a different version of curator from how it will run in production. So
it ends up being a NOOP with masking errors
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2496
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2500
+1
For storm-kafka-client I think the hangs are likely in the tests that run a
local Kafka instance. I've had those tests hang if I have a Kafka instance
running locally and I forget to close
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2494
> e.g. If we rename the enum property AT_LEAST_ONCE to something else, only
one file be affected.
I don't think that's a concern, because we're very unlikely to do it. The
enum values are part
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2492
@dujiashu Take a look in storm-kafka/target/checkstyle-violations.xml.
Please also raise an issue for this at https://issues.apache.org/jira, then
rename this PR to contain the issue number
Github user dujiashu commented on the issue:
https://github.com/apache/storm/pull/2492
how can I pass the checkstyle? Thanks for help.
---
32 matches
Mail list logo
