[GitHub] storm pull request #2528: [STORM-2901]: Reuse ZK connection for Nimbus [for ...

[danny0405]

GitHub user danny0405 opened a pull request:

https://github.com/apache/storm/pull/2528

[STORM-2901]: Reuse ZK connection for Nimbus [for 1.x-branch]

@HeartSaVioR 
This is the 1.x-branch patch.

The original PR is here: [#2522](https://github.com/apache/storm/pull/2522).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danny0405/storm reuse-zk-1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2528


commit 60dfa7d1b3c8e2500a64db3de38393354046
Author: chenyuzhao 
Date:   2018-01-23T04:42:46Z

STORM-2901: Reuse ZK connection for Nimbus for 1.x-branch




---

[GitHub] storm pull request #2527: STORM-2906 Pick HBase delegation token properly wh...

[HeartSaVioR]

GitHub user HeartSaVioR opened a pull request:

https://github.com/apache/storm/pull/2527

STORM-2906 Pick HBase delegation token properly while handling HBase …

…auth via delegation token

Please refer [STORM-2906](https://issues.apache.org/jira/browse/STORM-2906) 
to see more details.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HeartSaVioR/storm STORM-2906

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2527


commit d291f39c9aa6e29184a2712797e956b42cae3293
Author: Jungtaek Lim 
Date:   2018-01-23T04:34:22Z

STORM-2906 Pick HBase delegation token properly while handling HBase auth 
via delegation token




---

[GitHub] storm pull request #2526: STORM-2904: Document Metrics V2

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2526


---

[GitHub] storm issue #2526: STORM-2904: Document Metrics V2

[ptgoetz]

Github user ptgoetz commented on the issue:

https://github.com/apache/storm/pull/2526
  
@HeartSaVioR Fixed.


---

[GitHub] storm pull request #2526: STORM-2904: Document Metrics V2

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2526#discussion_r163073567
  
--- Diff: docs/index.md ---
@@ -80,7 +80,7 @@ But small change will not affect the user experience. We 
will notify the user wh
 * [Distributed RPC](Distributed-RPC.html)
 * [Transactional topologies](Transactional-topologies.html)
 * [Hooks](Hooks.html)
-* [Metrics](Metrics.html)
+* [Metrics](metrics_v2.html)
--- End diff --

Maybe keeping deprecated metrics doc would help, though we would want to be 
clear that they're deprecated. 
There's explanation regarding built-in metrics in previous metrics doc, but 
it may look odd to get built-in metrics into metrics V2 doc, because only small 
set of metrics are available in metrics V2 while we don't migrate them. Users 
still need metrics V1 for them.


---

[GitHub] storm pull request #2504: STORM-2887: store metrics into RocksDB

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2504


---

[GitHub] storm issue #2504: STORM-2887: store metrics into RocksDB

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2504
  
@agresch Thanks for handling the issue. Merging.


---

[GitHub] storm pull request #2526: STORM-2904: Document Metrics V2

[ptgoetz]

GitHub user ptgoetz opened a pull request:

https://github.com/apache/storm/pull/2526

STORM-2904: Document Metrics V2

Documentation only. No code changes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptgoetz/storm metrics_v2_docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2526


commit 7239bbda655df48d263ccbfa298de871e1c07358
Author: P. Taylor Goetz 
Date:   2018-01-22T21:04:19Z

STORM-2904: Document Metrics V2




---

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2203


---

[GitHub] storm pull request #2525: [STORM-2901] Fix BlobSynchronizer zk-client non se...

[danny0405]

GitHub user danny0405 opened a pull request:

https://github.com/apache/storm/pull/2525

[STORM-2901] Fix BlobSynchronizer zk-client non set problem

@HeartSaVioR 
Really sorry that i copied the code from previous PR and miss one line, i 
will try to use rebase for the later on PRS' commits.

Please help me to merge this in and i'm doing the 1.x-branch patch.

The original PR is here: [#2522](https://github.com/apache/storm/pull/2522)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danny0405/storm fix-blob

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2525


commit 326afbe6288046a89254a089e9384930ca76713c
Author: chenyuzhao 
Date:   2018-01-22T14:29:57Z

fix BlobSynchronizer zk-client non set




---

[GitHub] storm issue #2504: STORM-2887: store metrics into RocksDB

[agresch]

Github user agresch commented on the issue:

https://github.com/apache/storm/pull/2504
  
yes, removing the line of space fixed the issue for me.  Thanks. 


---

[GitHub] storm pull request #2522: [STORM-2901] Reuse ZK connection for getKeySequenc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2522


---

[GitHub] storm issue #2522: [STORM-2901] Reuse ZK connection for getKeySequenceNumber...

[danny0405]

Github user danny0405 commented on the issue:

https://github.com/apache/storm/pull/2522
  
@HeartSaVioR 
Done.


---

[GitHub] storm issue #2522: [STORM-2901] Reuse ZK connection for getKeySequenceNumber...

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2522
  
@danny0405 
Could you change your commit title to include issue number as well? Like 
`STORM-2901: Reuse ZK connection for Nimbus` given that we modified more than 
getKeySequenceNumber.

You can `git commit --amend` to modify your previous commit, and `git push 
--force` to update your PR.

Please let me know after you update. Thanks in advance!


---

[GitHub] storm issue #2522: [STORM-2901] Reuse ZK connection for getKeySequenceNumber...

[danny0405]

Github user danny0405 commented on the issue:

https://github.com/apache/storm/pull/2522
  
@HeartSaVioR 
I have fire a bug issue ticket here: 
[#STORM-2905](https://issues.apache.org/jira/browse/STORM-2905)


---

[GitHub] storm issue #2524: STORM-2903: (follow up) Log token identifier and username...

[omkreddy]

Github user omkreddy commented on the issue:

https://github.com/apache/storm/pull/2524
  
@HeartSaVioR @satishd  follow-up PR for STORM-2903


---

[GitHub] storm pull request #2524: STORM-2903: (follow up) Log token identifier and u...

[omkreddy]

GitHub user omkreddy opened a pull request:

https://github.com/apache/storm/pull/2524

STORM-2903: (follow up) Log token identifier and username associated with 
token identifier



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omkreddy/storm STORM-2903-1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2524.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2524


commit 05890efcf0a509f6fabd2e89c4027eaffd497d68
Author: Manikumar Reddy 
Date:   2018-01-22T10:18:08Z

STORM-2903: (follow up) Log token identifier and username associated with 
token identifier




---

[GitHub] storm pull request #2523: STORM-2903: (follow up) Log token identifier and u...

[omkreddy]

GitHub user omkreddy opened a pull request:

https://github.com/apache/storm/pull/2523

STORM-2903: (follow up) Log token identifier and username associated with 
token identifier



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omkreddy/storm STORM-2903

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2523


commit 841586151e241beb87a42d55f5a7a500428b0c99
Author: Manikumar Reddy 
Date:   2018-01-22T10:10:10Z

STORM-2903: (follow up) Log token identifier and username associated with 
token identifier




---

[GitHub] storm pull request #2522: [STORM-2901] Reuse ZK connection for getKeySequenc...

[danny0405]

GitHub user danny0405 opened a pull request:

https://github.com/apache/storm/pull/2522

[STORM-2901] Reuse ZK connection for getKeySequenceNumber [for 2.0.0 storm]

Reuse connections for nimbus blob-store keys registration when restarting.

Also for storm-code setup.

This is the JIRA: 
[#STORM-2901](https://issues.apache.org/jira/browse/STORM-2901)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danny0405/storm reuse-zk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2522


commit c10bb03ecdf8fbee834124419d0368429f3f1919
Author: chenyuzhao 
Date:   2018-01-22T10:12:15Z

reuse ZK for STORM-2901




---

[GitHub] storm pull request #2474: STORM-2862: More flexible logging in multilang

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2474


---

[GitHub] storm issue #2474: STORM-2862: More flexible logging in multilang

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2474
  
+1 prior to merge. (It's kind of porting back.)


---

[GitHub] storm pull request #2475: STORM-2862: More flexible logging in multilang

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2475


---

[GitHub] storm pull request #2521: STORM-2862: More flexible logging in multilang

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2521


---

[GitHub] storm issue #2521: STORM-2862: More flexible logging in multilang

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2521
  
+1 prior to merge. (It's kind of porting back.)


---

[GitHub] storm issue #2475: STORM-2862: More flexible logging in multilang

[hmcc]

Github user hmcc commented on the issue:

https://github.com/apache/storm/pull/2475
  
1.1.x PR: #2521. It looks like #2320 is already in 1.1.x branch, thanks!


---

[GitHub] storm pull request #2521: STORM-2862: More flexible logging in multilang

[hmcc]

GitHub user hmcc opened a pull request:

https://github.com/apache/storm/pull/2521

STORM-2862: More flexible logging in multilang

Connected to https://issues.apache.org/jira/browse/STORM-2862; 1.1.x 
version of apache/storm#2475.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hmcc/storm STORM-2862-1.1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2521


commit dc65d3bb9dceab31191ab49e365bd25b17f46377
Author: Heather McCartney 
Date:   2017-12-20T10:14:53Z

STORM-2862: Move multilang logging to a shared class and make this class 
configurable.




---

[GitHub] storm issue #2475: STORM-2862: More flexible logging in multilang

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2475
  
@hmcc Really appreciated to your help! Please feel free to submit one. It 
would be easy if cherry-pick doesn't make any conflict so I'm normally OK with 
porting back between 1.x and 1.1.x.


---

[GitHub] storm issue #2475: STORM-2862: More flexible logging in multilang

[hmcc]

Github user hmcc commented on the issue:

https://github.com/apache/storm/pull/2475
  
@HeartSaVioR done.

If 1.1.2 is the next release then in an ideal world we'd get both this and 
#2320 in there. Is that possible? I don't want to add to your workload so I'm 
more than happy to create the PRs if so. 

If it's too late for #2320 then we'll wait for 1.2.0 (and I'll make sure I 
create 1.1.x PRs as well in future).


---

[GitHub] storm issue #2517: [STORM-2901] Reuse ZK connection for getKeySequenceNumber

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2517
  
@danny0405 
FYI, you can rebase your branch and force push to update your PR without 
closing.


---

[GitHub] storm issue #2475: STORM-2862: More flexible logging in multilang

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2475
  
@hmcc 
Could you change your commit title to include issue number as well? Like 
`STORM-2862: Move multilang logging to a shared class and make this class 
configurable`.

I guess I could port back your PR against 1.x-branch into 1.1.x-branch if 
there's no (or small) conflict.


---

[GitHub] storm issue #2475: STORM-2862: More flexible logging in multilang

[hmcc]

Github user hmcc commented on the issue:

https://github.com/apache/storm/pull/2475
  
@HeartSaVioR, I understand that the 1.2.0 and 1.1.2 releases might be 
coming soon?

Do you know if 1.1.2 is going to be much before 1.2.0? If so, would it be 
OK if I made a PR for the 1.1.x branch too?


---

[GitHub] storm pull request #2517: [STORM-2901] Reuse ZK connection for getKeySequenc...

[danny0405]

Github user danny0405 closed the pull request at:

https://github.com/apache/storm/pull/2517


---