[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @danny0405 Now Bobby's patch for STORM-2898 is merged. Could you start working on follow-up work based on STORM-2898? Thanks in advance! ---

Re: [VOTE] Release Apache Storm 1.0.6 (rc3)

*serialized* ;) > On Feb 9, 2018, at 12:48 AM, P. Taylor Goetz wrote: > > I’d have to check (can’t right now), but I think that class gets sterilized > via kryo. If that’s not the case, yes, it could cause problems. > > I think the safest option would be to remove the

Re: [VOTE] Release Apache Storm 1.0.6 (rc3)

I’d have to check (can’t right now), but I think that class gets sterilized via kryo. If that’s not the case, yes, it could cause problems. I think the safest option would be to remove the serialversionuid. -Taylor > On Feb 8, 2018, at 5:36 PM, Erik Weathers >

Re: [VOTE] Release Apache Storm 1.0.6 (rc3)

I'm not 100% sure either, but I assume Storm serializes topology information into thrift structure (at least Grouping.fields() takes List instead of Fields), so unless nodes are using different versions of Storm (which we never support), that would be safe. If it's not safe, we already broke

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2531 ---

[GitHub] storm issue #2502: new PR for STORM-2306 : Messaging subsystem redesign

Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2502 @revans2 and @HeartSaVioR Just rebased this PR and also included the fix for the making ExecutorTransfer.tryTransfer() thread safe to allow concurrent emits from background threads spun by

[GitHub] storm issue #2554: STORM-2939 add WorkerMetricsProcessor interface

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2554 Some questions: 1. Will we support combination of metricstore and metricprocessor? For example, NimbusMetricProcessor as processor but using HBaseStore as store. If metric store and

[GitHub] storm pull request #2502: new PR for STORM-2306 : Messaging subsystem redesi...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2502#discussion_r167097905 --- Diff: storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java --- @@ -17,72 +17,124 @@ */ package org.apache.storm.executor;

[GitHub] storm pull request #2551: [STORM-2940] Dynamically set the CAPACITY value of...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2551#discussion_r167094514 --- Diff: storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java --- @@ -85,6 +85,7 @@ public void prepare(WorkerTopologyContext

[GitHub] storm issue #2502: new PR for STORM-2306 : Messaging subsystem redesign

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2502 This looks really really good. I ran through the unit tests and some performance tests and everything looks great. Now I feel like I can get excited about this going in. I am going to spend

[GitHub] storm issue #2551: [STORM-2940] Dynamically set the CAPACITY value of LoadAw...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2551 @HeartSaVioR @revans2 Could you please take a look again? If it feels good, I will squash the commits. Thanks ---

Re: [VOTE] Release Apache Storm 1.0.6 (rc3)

Something I just realized -- in the storm-kafka-client stomping into 1.0.x-branch PR, I backported a change to Fields.java which added a serialVersionUID. Could that potentially break topologies when you upgrade storm-core on the servers (nimbus, workers) from 1.0.{1..5} to 1.0.6? I'm not super

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2554 STORM-2939 add WorkerMetricsProcessor interface This adds the WorkerMetricsProcessor interface. The default implementation executes the current code that sends metric data to Nimbus for insertion,

[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2487 @kishorvpatil If we are not going to merge this into master could you close it? ---

Re: [VOTE] Release Apache Storm 1.0.6 (rc3)

+1 I built the code from the git tag, ran all the unit tests (which passed the first time), and ran some tests on a single node cluster. It all looked good. - Bobby On Thu, Feb 8, 2018 at 1:22 PM P. Taylor Goetz wrote: > This is a call to vote on releasing Apache Storm

[GitHub] storm pull request #2552: STORM-2941: Fix checkstyle issues in KafkaSpout

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2552 ---

Re: [VOTE] Release Apache Storm 1.1.2 (rc3)

+1 I built from the tag and did some basic tests on a single node cluster. I am disappointed that it took me 7 times to get all of the unit tests to pass for the build, but I don't think it should block a release. - Bobby On Thu, Feb 8, 2018 at 11:48 AM P. Taylor Goetz

[GitHub] storm issue #2553: STORM-2935 update autocredential metric documentation

Github user agresch commented on the issue: https://github.com/apache/storm/pull/2553 @revans2 - added the missing documentation you requested ---

[GitHub] storm pull request #2553: STORM-2935 update autocredential metric documentat...

GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2553 STORM-2935 update autocredential metric documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/agresch/storm agresch_autocredential_doc

[VOTE] Release Apache Storm 1.0.6 (rc3)

This is a call to vote on releasing Apache Storm 1.0.6 (rc3) Full list of changes in this release: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.6-rc3/RELEASE_NOTES.html The tag/commit to be voted upon is v1.0.6:

[VOTE] Release Apache Storm 1.1.2 (rc3)

This is a call to vote on releasing Apache Storm 1.1.2 (rc3) Full list of changes in this release: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.1.2-rc3/RELEASE_NOTES.html The tag/commit to be voted upon is v1.1.2:

[GitHub] storm issue #2531: STORM-2898: Support for WorkerToken authentication

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2531 The changes are done. The build passes when I disable check style, and check style passes for the sub-projects that I modified. If I can get a final +1 on renaming the one Method that

[GitHub] storm issue #2531: STORM-2898: Support for WorkerToken authentication

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2531 I will fix the nit, but I was also talking to some security people and I am going to switch the signature algorithm from "HmacSHA1" to "HmacSHA256". Not because there are any issues with SHA1, this

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

Update: I also merged the patch for 1.0.x-branch. Thanks all for taking valuable efforts and time to participate this topic and making it possible so quickly. Now release phase of both 1.1.2 and 1.0.6 can be restart. 2018년 2월 8일 (목) 오전 6:30, Jungtaek Lim 님이 작성: > Update: I

[GitHub] storm pull request #2550: STORM-2937: Overwrite latest storm-kafka-client 1....

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2550 ---