[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates

2018-06-07 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2689
  
@vesense I am trying to get the RocketMQ example topology up and running so 
I can manually test that it is working, but there is no documentation on how to 
do it.  I managed to download RocketMQ and set it up so there are no more 
exceptions in the logs, but I am no data is flowing.  Do you happen to have a 
tool or instructions on how to publish and read the appropriate messages 
to/from the corresponding queues?


---


[GitHub] storm issue #2708: STORM-3098: Fixed method filterChangingBlobsFor()

2018-06-07 Thread zd-project
Github user zd-project commented on the issue:

https://github.com/apache/storm/pull/2708
  
I extended the test to cover the testing of filterChangingBlob now.


---


Re: Running tests via Clojure REPL

2018-06-07 Thread Kishorkumar Patil
Please run
On master branch, please run `mvn install -DskipTests;` before running *
./dev-tools/test-ns.py org.apache.storm.drpc-test*.

main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ storm-core ---
[INFO]
[INFO] --- clojure-maven-plugin:1.7.1:test (test-clojure) @ storm-core ---
Running org.apache.storm.drpc-test
Tests run: 7, Passed: 14, Failures: 0, Errors: 0




Kishor

On Thu, Jun 7, 2018 at 1:11 PM, Vivian Kong  wrote:

> Thanks Kishor! I tried the script but it didn't seem to be working. It
> didn't find any tests to run:
>
> ...
> main:
> [INFO] Executed tasks
> [INFO]
> [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ storm-core
> ---
> [INFO]
> [INFO] --- clojure-maven-plugin:1.7.1:test (test-clojure) @ storm-core ---
> Picked up _JAVA_OPTIONS: -Xmx4096m
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> ...
>
> Regards,
>
> Vivian Kong
> Linux on z Systems Open Source Ecosystem
> IBM Canada Toronto Lab
>
> [image: Inactive hide details for Kishorkumar Patil ---2018/06/07 11:28:00
> AM---Try *./dev-tools/test-ns.py org.apache.storm.drcp_test*]Kishorkumar
> Patil ---2018/06/07 11:28:00 AM---Try *./dev-tools/test-ns.py
> org.apache.storm.drcp_test*
>
> From: Kishorkumar Patil 
> To: dev@storm.apache.org
> Date: 2018/06/07 11:28 AM
> Subject: Re: Running tests via Clojure REPL
> --
>
>
>
> Try
>
> *./dev-tools/test-ns.py org.apache.storm.drcp_test*
>
>
>
> Kishor
>
> On Thu, Jun 7, 2018 at 11:00 AM, Vivian Kong  wrote:
>
> >
> >
> > Hi,
> >
> > I am following
> >
> https://github.com/apache/storm/blob/master/DEVELOPER.md#testing-1 to try
>
> > to run a subset of storm-core tests via the Clojure REPL but I couldn't
> > figured out how to do that.  Tried the following but hit an exception
> (see
> > below).  I appreciate any pointers/examples on how to set up and run the
> > tests.  Thanks!
> >
> >
> > # clojure storm-core/test/clj/org/apache/storm/drpc_test.clj
> > Picked up _JAVA_OPTIONS: -Xmx4096m
> > Exception in thread "main" java.lang.ClassNotFoundException:
> > org.apache.storm.drpc.ReturnResults,
> > compiling:(/root/storm/storm-core/test/clj/org/apache/
> > storm/drpc_test.clj:1:1)
> > at clojure.lang.Compiler.load(Compiler.java:7526)
> > at clojure.lang.Compiler.loadFile(Compiler.java:7452)
> > at clojure.main$load_script.invokeStatic(main.clj:278)
> > at clojure.main$script_opt.invokeStatic(main.clj:338)
> > at clojure.main$script_opt.invoke(main.clj:333)
> > at clojure.main$main.invokeStatic(main.clj:424)
> > at clojure.main$main.doInvoke(main.clj:387)
> > at clojure.lang.RestFn.applyTo(RestFn.java:137)
> > at clojure.lang.Var.applyTo(Var.java:702)
> > at clojure.main.main(main.java:37)
> > Caused by: java.lang.ClassNotFoundException:
> > org.apache.storm.drpc.ReturnResults
> > at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> > at clojure.lang.DynamicClassLoader.findClass
> > (DynamicClassLoader.java:69)
> > at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> > at clojure.lang.DynamicClassLoader.loadClass
> > (DynamicClassLoader.java:77)
> > at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> > at java.lang.Class.forName0(Native Method)
> > at java.lang.Class.forName(Class.java:348)
> > at clojure.lang.RT.classForName(RT.java:2204)
> > at clojure.lang.RT.classForNameNonLoading(RT.java:2217)
> > at org.apache.storm.drpc_test$eval147
> > $loading__6434__auto148.invoke(drpc_test.clj:16)
> > at org.apache.storm.drpc_test$eval147.invokeStatic
> > (drpc_test.clj:16)
> > at org.apache.storm.drpc_test$eval147.invoke(drpc_test.clj:16)
> > at clojure.lang.Compiler.eval(Compiler.java:7062)
> > at clojure.lang.Compiler.eval(Compiler.java:7051)
> > at clojure.lang.Compiler.load(Compiler.java:7514)
> > ... 9 more
> >
> >
> >
> > Regards,
> >
> > Vivian Kong
> > Linux on z Systems Open Source Ecosystem
> > IBM Canada Toronto Lab
> >
>
>
>
>


[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates

2018-06-07 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2689
  
@ptgoetz I am trying to run all of the examples/tests I can to be sure that 
I didn't break anything when I upgraded versions.  One of the issues I am 
running into is around the spring framework in the storm-jms-examples package.  
It looks like you wrote that code initially, or at least brought it in could 
you explain to me how to run it?  I am having no luck making it work on any 
version of storm I have tried.

```
442  [main] INFO  o.s.b.f.x.XmlBeanDefinitionReader - Loading XML bean 
definitions from class path resource [jms-activemq.xml]
Exception in thread "main" 
org.springframework.beans.factory.parsing.BeanDefinitionParsingException: 
Configuration problem: Unable to locate Spring NamespaceHandler for XML schema 
namespace [http://activemq.apache.org/schema/core]
Offending resource: class path resource [jms-activemq.xml]
```


---


[GitHub] storm issue #2707: STORM-3097: Remove storm-druid

2018-06-07 Thread srdo
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2707
  
Thanks, +1 again


---


Re: Running tests via Clojure REPL

2018-06-07 Thread Vivian Kong

Thanks Kishor!  I tried the script but it didn't seem to be working.  It
didn't find any tests to run:

...
main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ storm-core
---
[INFO]
[INFO] --- clojure-maven-plugin:1.7.1:test (test-clojure) @ storm-core ---
Picked up _JAVA_OPTIONS: -Xmx4096m
[INFO]

[INFO] BUILD SUCCESS
[INFO]

...

Regards,

Vivian Kong
Linux on z Systems Open Source Ecosystem
IBM Canada Toronto Lab



From:   Kishorkumar Patil 
To: dev@storm.apache.org
Date:   2018/06/07 11:28 AM
Subject:Re: Running tests via Clojure REPL



Try

*./dev-tools/test-ns.py org.apache.storm.drcp_test*


Kishor

On Thu, Jun 7, 2018 at 11:00 AM, Vivian Kong  wrote:

>
>
> Hi,
>
> I am following
>
https://github.com/apache/storm/blob/master/DEVELOPER.md#testing-1
 to try
> to run a subset of storm-core tests via the Clojure REPL but I couldn't
> figured out how to do that.  Tried the following but hit an exception
(see
> below).  I appreciate any pointers/examples on how to set up and run the
> tests.  Thanks!
>
>
> # clojure storm-core/test/clj/org/apache/storm/drpc_test.clj
> Picked up _JAVA_OPTIONS: -Xmx4096m
> Exception in thread "main" java.lang.ClassNotFoundException:
> org.apache.storm.drpc.ReturnResults,
> compiling:(/root/storm/storm-core/test/clj/org/apache/
> storm/drpc_test.clj:1:1)
> at clojure.lang.Compiler.load(Compiler.java:7526)
> at clojure.lang.Compiler.loadFile(Compiler.java:7452)
> at clojure.main$load_script.invokeStatic(main.clj:278)
> at clojure.main$script_opt.invokeStatic(main.clj:338)
> at clojure.main$script_opt.invoke(main.clj:333)
> at clojure.main$main.invokeStatic(main.clj:424)
> at clojure.main$main.doInvoke(main.clj:387)
> at clojure.lang.RestFn.applyTo(RestFn.java:137)
> at clojure.lang.Var.applyTo(Var.java:702)
> at clojure.main.main(main.java:37)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.storm.drpc.ReturnResults
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at clojure.lang.DynamicClassLoader.findClass
> (DynamicClassLoader.java:69)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at clojure.lang.DynamicClassLoader.loadClass
> (DynamicClassLoader.java:77)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:348)
> at clojure.lang.RT.classForName(RT.java:2204)
> at clojure.lang.RT.classForNameNonLoading(RT.java:2217)
> at org.apache.storm.drpc_test$eval147
> $loading__6434__auto148.invoke(drpc_test.clj:16)
> at org.apache.storm.drpc_test$eval147.invokeStatic
> (drpc_test.clj:16)
> at org.apache.storm.drpc_test$eval147.invoke(drpc_test.clj:16)
> at clojure.lang.Compiler.eval(Compiler.java:7062)
> at clojure.lang.Compiler.eval(Compiler.java:7051)
> at clojure.lang.Compiler.load(Compiler.java:7514)
> ... 9 more
>
>
>
> Regards,
>
> Vivian Kong
> Linux on z Systems Open Source Ecosystem
> IBM Canada Toronto Lab
>




[GitHub] storm issue #2706: STORM-3097: deprecate storm-druid (1.x)

2018-06-07 Thread ptgoetz
Github user ptgoetz commented on the issue:

https://github.com/apache/storm/pull/2706
  
+1


---


[GitHub] storm issue #2703: [STORM-3094] : Added topology name validation at client s...

2018-06-07 Thread ManoharVanam
Github user ManoharVanam commented on the issue:

https://github.com/apache/storm/pull/2703
  
Yes , here we are handling two things,
1. Fail fast without uploading the jar
2. Giving clear message to the user at the client side.


---


[GitHub] storm pull request #2690: STORM-3061: Clean up some storm-druid dependencies

2018-06-07 Thread revans2
Github user revans2 closed the pull request at:

https://github.com/apache/storm/pull/2690


---


[GitHub] storm issue #2690: STORM-3061: Clean up some storm-druid dependencies

2018-06-07 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2690
  
Because of STORM-3097 #2707 I am closing this pull request.  I might reopen 
it if STORM-3097 goes a different direction.


---


[GitHub] storm issue #2706: STORM-3097: deprecate storm-druid (1.x)

2018-06-07 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2706
  
Thanks @srdo I updated the docs to include the deprecated message.


---


[GitHub] storm issue #2707: STORM-3097: Remove storm-druid

2018-06-07 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2707
  
Thanks @srdo I removed storm-druid.md and removed the link form index.md 
(which was the only one I could find)


---


[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-06-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2698


---


Re: Running tests via Clojure REPL

2018-06-07 Thread Kishorkumar Patil
Try

*./dev-tools/test-ns.py org.apache.storm.drcp_test*


Kishor

On Thu, Jun 7, 2018 at 11:00 AM, Vivian Kong  wrote:

>
>
> Hi,
>
> I am following
> https://github.com/apache/storm/blob/master/DEVELOPER.md#testing-1 to try
> to run a subset of storm-core tests via the Clojure REPL but I couldn't
> figured out how to do that.  Tried the following but hit an exception (see
> below).  I appreciate any pointers/examples on how to set up and run the
> tests.  Thanks!
>
>
> # clojure storm-core/test/clj/org/apache/storm/drpc_test.clj
> Picked up _JAVA_OPTIONS: -Xmx4096m
> Exception in thread "main" java.lang.ClassNotFoundException:
> org.apache.storm.drpc.ReturnResults,
> compiling:(/root/storm/storm-core/test/clj/org/apache/
> storm/drpc_test.clj:1:1)
> at clojure.lang.Compiler.load(Compiler.java:7526)
> at clojure.lang.Compiler.loadFile(Compiler.java:7452)
> at clojure.main$load_script.invokeStatic(main.clj:278)
> at clojure.main$script_opt.invokeStatic(main.clj:338)
> at clojure.main$script_opt.invoke(main.clj:333)
> at clojure.main$main.invokeStatic(main.clj:424)
> at clojure.main$main.doInvoke(main.clj:387)
> at clojure.lang.RestFn.applyTo(RestFn.java:137)
> at clojure.lang.Var.applyTo(Var.java:702)
> at clojure.main.main(main.java:37)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.storm.drpc.ReturnResults
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at clojure.lang.DynamicClassLoader.findClass
> (DynamicClassLoader.java:69)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at clojure.lang.DynamicClassLoader.loadClass
> (DynamicClassLoader.java:77)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:348)
> at clojure.lang.RT.classForName(RT.java:2204)
> at clojure.lang.RT.classForNameNonLoading(RT.java:2217)
> at org.apache.storm.drpc_test$eval147
> $loading__6434__auto148.invoke(drpc_test.clj:16)
> at org.apache.storm.drpc_test$eval147.invokeStatic
> (drpc_test.clj:16)
> at org.apache.storm.drpc_test$eval147.invoke(drpc_test.clj:16)
> at clojure.lang.Compiler.eval(Compiler.java:7062)
> at clojure.lang.Compiler.eval(Compiler.java:7051)
> at clojure.lang.Compiler.load(Compiler.java:7514)
> ... 9 more
>
>
>
> Regards,
>
> Vivian Kong
> Linux on z Systems Open Source Ecosystem
> IBM Canada Toronto Lab
>


Running tests via Clojure REPL

2018-06-07 Thread Vivian Kong


Hi,

I am following
https://github.com/apache/storm/blob/master/DEVELOPER.md#testing-1 to try
to run a subset of storm-core tests via the Clojure REPL but I couldn't
figured out how to do that.  Tried the following but hit an exception (see
below).  I appreciate any pointers/examples on how to set up and run the
tests.  Thanks!


# clojure storm-core/test/clj/org/apache/storm/drpc_test.clj
Picked up _JAVA_OPTIONS: -Xmx4096m
Exception in thread "main" java.lang.ClassNotFoundException:
org.apache.storm.drpc.ReturnResults,
compiling:(/root/storm/storm-core/test/clj/org/apache/storm/drpc_test.clj:1:1)
at clojure.lang.Compiler.load(Compiler.java:7526)
at clojure.lang.Compiler.loadFile(Compiler.java:7452)
at clojure.main$load_script.invokeStatic(main.clj:278)
at clojure.main$script_opt.invokeStatic(main.clj:338)
at clojure.main$script_opt.invoke(main.clj:333)
at clojure.main$main.invokeStatic(main.clj:424)
at clojure.main$main.doInvoke(main.clj:387)
at clojure.lang.RestFn.applyTo(RestFn.java:137)
at clojure.lang.Var.applyTo(Var.java:702)
at clojure.main.main(main.java:37)
Caused by: java.lang.ClassNotFoundException:
org.apache.storm.drpc.ReturnResults
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at clojure.lang.DynamicClassLoader.findClass
(DynamicClassLoader.java:69)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at clojure.lang.DynamicClassLoader.loadClass
(DynamicClassLoader.java:77)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:348)
at clojure.lang.RT.classForName(RT.java:2204)
at clojure.lang.RT.classForNameNonLoading(RT.java:2217)
at org.apache.storm.drpc_test$eval147
$loading__6434__auto148.invoke(drpc_test.clj:16)
at org.apache.storm.drpc_test$eval147.invokeStatic
(drpc_test.clj:16)
at org.apache.storm.drpc_test$eval147.invoke(drpc_test.clj:16)
at clojure.lang.Compiler.eval(Compiler.java:7062)
at clojure.lang.Compiler.eval(Compiler.java:7051)
at clojure.lang.Compiler.load(Compiler.java:7514)
... 9 more



Regards,

Vivian Kong
Linux on z Systems Open Source Ecosystem
IBM Canada Toronto Lab


[GitHub] storm issue #2708: STORM-3098: Fixed method filterChangingBlobsFor()

2018-06-07 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2708
  
Conceptually the change looks like a good fix.

When I first wrote the code I would launch a topology which depended on 
several blobs, some that required a relaunch of the worker and others that 
didn't.  I then manually verified that the worker was relaunched when I changed 
the ones that required a relaunch and wasn't relaunched for ones that didn't 
need it.  It would be good to at least verify that it is still working after 
this change, and more importantly is this code needed at all if it was working 
before.


---


[GitHub] storm pull request #2708: STORM-3098: Fixed method filterChangingBlobsFor()

2018-06-07 Thread zd-project
GitHub user zd-project opened a pull request:

https://github.com/apache/storm/pull/2708

STORM-3098: Fixed method filterChangingBlobsFor()



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zd-project/storm STORM-3098

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2708


commit 498da9e77cec4d5cb9dfbb1044cb9634f1ff0422
Author: Zhengdai Hu 
Date:   2018-06-07T14:19:44Z

STORM-3098: Fixed method filterChangingBlobsFor()




---