Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@HeartSaVioR
Sorry, i have left my company and do not maintain large storm cluster now,
i can only test the numbers on my laptop, i will make a diagram this weekend.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405
Providing some numbers would help persuading others if it is easy to
measure. If it is not easy to get the numbers, I'm OK to skip and compare the
difference of diagram/code.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2731
My 2 cents, looks like summary of JIRA represents the issue and which we
are addressing better than PR/commit title.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2721
@revans2 , i have refactored the code so that we check for "user.name" in
the normal container and the result of `getWorkerUser` in the
RunAsUserContainer.
The `getWorkerUser` is
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2732#discussion_r197264602
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -3557,6 +3570,14 @@ public ByteBuffer downloadBlobChunk(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2732#discussion_r197260303
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -3557,6 +3570,14 @@ public ByteBuffer downloadBlobChunk(String
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2732
STORM-3117 prevent deleting blobs while topologies still active
Prevented crashing nimbus if blob is deleted during a getClusterInfo call.
However, once nimbus is restarted, if there was an active
Github user milantracy commented on the issue:
https://github.com/apache/storm/pull/2729
@srdo @danny0405 squashed, thanks for reviewing :)
---
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2731
STORM-3118 fix netty buffer usage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agresch/storm agresch_pacemaker_netty
Alternatively you can
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2729
@milantracy Looks great. Please squash to one commit, and we can merge once
the 24 hour waiting period is over.
---
Github user milantracy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2729#discussion_r197235311
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/spout/IPartitionedTridentSpout.java
---
@@ -36,7 +37,7 @@
interface Coordinator {
Github user kristopherkane closed the pull request at:
https://github.com/apache/storm/pull/1327
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2729#discussion_r197162525
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/spout/IPartitionedTridentSpout.java
---
@@ -36,7 +37,7 @@
interface Coordinator {
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2729#discussion_r197158924
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/spout/IPartitionedTridentSpout.java
---
@@ -36,7 +37,7 @@
interface Coordinator {
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2729
+1, looks good.
---
Github user aandis commented on the issue:
https://github.com/apache/storm/pull/2719
In our case, we have copied the hive
[dependencies](https://github.com/apache/storm/blob/4137328b75c06771f84414c3c2113e2d1c757c08/external/storm-hive/pom.xml#L54)
into our pom with the right version
GitHub user palashchauhan opened a pull request:
https://github.com/apache/storm/pull/2730
akan
made a new directory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/palashchauhan/storm v1
Alternatively you can review and apply
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2726
@HeartSaVioR Sure, thanks.
---
18 matches
Mail list logo
