Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207771586
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/PreparableCallback.java
---
@@ -0,0 +1,32 @@
+/**
+ * Licensed to
GitHub user govind-menon opened a pull request:
https://github.com/apache/storm/pull/2797
STORM-3179: Fixing getNimbusSummary in Storm API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/govind-menon/storm STORM-3179
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
I've added calls to report to the branch, the tests are running at
https://travis-ci.org/srdo/storm/builds/413332618.
Unless the test specifies another configuration file, I would expect us to
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
Thanks again for helping me out of this issue though. Hope this don't
create too much trouble for you.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
Also, I just dug into the error code you suggested. It turned out to be
caused by heartbeatTimer (instance of StormTimer) in Supervisor in
AsyncLocalizerTest.testKeyNotFoundException. But I don't
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
Okay that alerted me one thing. What's our config file for the testing? If
it doesn't use ScheduledReporter for testing, this PR shouldn't make a matter
at all.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
I can't see changes in your link, so I looked into your latest change in
branch `non-static-metrics`. Please correct me if I interpret your code wrong.
Your implementation didn't actually
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
It should. Take a look at
https://github.com/srdo/storm/compare/892179527b5a...0916fae11cb2#diff-9c4945e8e924565ca1f071435f4711e9.
If you compare the daemon classes (Nimbus, Supervisor etc.) there
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
Interesting. Does your implementation also guarantee flushing all metrics
upon exit?
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
Unless it turns out to be easy to fix the test errors, I'd like to propose
not merging this and fixing this issue as part of making the metrics registry
non-static. I added reporter shutdowns to all
Github user govind-menon commented on the issue:
https://github.com/apache/storm/pull/2796
@HeartSaVioR 2 left.
---
GitHub user govind-menon opened a pull request:
https://github.com/apache/storm/pull/2796
STORM-3181: Fix for completeLatency in TopologyStats
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/govind-menon/storm STORM-3181
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2710
@HeartSaVioR @danny0405 Do you want to take a look again? Otherwise I think
it's good to merge it.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r208353770
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2807,7 +2808,14 @@ public void launchServer() throws Exception {
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
Right, sorry, didn't recheck the logs.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r208350201
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2807,7 +2808,14 @@ public void launchServer() throws Exception {
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
The lastest failure didn't provide an error code though.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
No, but like I said, I suspect that the exit code is being set by a call to
`Utils.exitProcess`. If you try changing some of the exit codes to be unique,
it's likely you'll be able to tell which call
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208340502
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java ---
@@ -365,6 +384,7 @@ void addReferencesToBlobs(PortAndAssignment pna,
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
I managed to fix the original timeout error by wrapping around a nimbus
gauge with exception handling code. However the PR still failed the
storm-server test due to error in starting fork. I
+1
On Tue, Aug 7, 2018 at 9:02 AM Alexandre Vermeerbergen <
avermeerber...@gmail.com> wrote:
> +1 for a Storm release 1.2.3 first (non binding)
>
> Alexandre Vermeerbergen
> Le mar. 7 août 2018 à 17:47, Stig Rohde Døssing
> a écrit :
> >
> > Hi devs,
> >
> > I've seen a couple of requests for
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208292571
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -346,6 +358,10 @@ public void cleanUp() throws IOException
+1 for a Storm release 1.2.3 first (non binding)
Alexandre Vermeerbergen
Le mar. 7 août 2018 à 17:47, Stig Rohde Døssing
a écrit :
>
> Hi devs,
>
> I've seen a couple of requests for releasing Storm 1.2.3 soon on the users
> list. I know we're currently working toward a release for Storm 2.0.0,
Sounds good to me. I’ll wait for others to weigh in to see if there’s anything
pending that should be included. But IMO we can release at any time.
-Taylor
> On Aug 7, 2018, at 11:46 AM, Stig Rohde Døssing
> wrote:
>
> Hi devs,
>
> I've seen a couple of requests for releasing Storm 1.2.3
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208286166
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -346,6 +358,10 @@ public void cleanUp() throws IOException
Hi devs,
I've seen a couple of requests for releasing Storm 1.2.3 soon on the users
list. I know we're currently working toward a release for Storm 2.0.0, but
I think it would be nice to release 1.2.3 first. It contains some decent
bugfixes, and also contains the deprecation of storm-druid. Last
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208279317
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
---
@@ -28,11 +29,14 @@
import
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208092337
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -346,6 +358,10 @@ public void cleanUp() throws IOException {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208095554
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -1008,6 +1015,13 @@ public void close() throws Exception {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208279468
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java ---
@@ -251,11 +261,18 @@ private LocalizedResource getUserFile(String
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208096352
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -1147,8 +1162,19 @@ public DynamicState
31 matches
Mail list logo
